TRIB-102, return the username along with the user ID in connectOutgoingMessageDTO #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/connect-page #165 +/- ##
==========================================================
+ Coverage 79.79% 80.08% +0.29%
- Complexity 529 531 +2
==========================================================
Files 77 77
Lines 1638 1662 +24
Branches 266 267 +1
==========================================================
+ Hits 1307 1331 +24
Misses 295 295
Partials 36 36 ☔ View full report in Codecov by Sentry. |
mrsbluerose
reviewed
Mar 19, 2024
| @@ -112,21 +113,32 @@ public List<ConnectOutgoingMessageDTO> handleConnectionIntent(String connectionI | |||
| if (connectionIntent == "") { | |||
| rtn.add(ConnectOutgoingMessageDTO.builder() | |||
| .message("Please confirm that you wish to connect.") | |||
| .to(toBeConnectedWithUserId) | |||
| .to(UsernameDTO.builder() | |||
| .userId(requestingUserId) | |||
There was a problem hiding this comment.
I believe when I first worked through this method, this message "Please confirm that you wish to connect" was going to the toBeConnectedWith user as a confirmation that they accept the connection. Is this actually for the requesting user?
There was a problem hiding this comment.
Yes, thank you. Good find. I've corrected it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.