Add Module for managing lists #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Commit adds a module, which can be used to manage blocklist of the pihole
Allows handling of allow and block lists with an interface influenced by the manage list role
This is due to a eror in the PiHole API, see: pi-hole/FTL#2377
This will lead to a lot faster updates, fixes sbarbett#3
|
Getting things to pass ansible-lint has introduced some conflicts with this PR that can't be automatically resolved. Can you rebase from the main repository and then plug your module back in. The main repo is now compliant with Ansible's linting requirements. |
|
Please try v1.1.0. I have refactored the lists modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation for an module, with an interface similar to manage_lists.
This Module is faster, as it doesn't spawn tasks for every list and is thus suitable for large collections of block lists.
This closes #3