feat(sbb-train-formation): introduce new types and refactoring #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: peer review required
jeripeierSBB
changed the title
kyubisation
reviewed
Nov 7, 2024
jeripeierSBB
commented
Nov 12, 2024
kyubisation
approved these changes
Nov 14, 2024
|
|
||
| @include sbb.if-forced-colors { | ||
| --sbb-train-formation-sector-line-color: CanvasText; | ||
| } | ||
| } | ||
|
|
||
| :host([hide-wagon-label]) { | ||
| --sbb-train-formation-wagon-label-display: none; | ||
| // TODO: Move to sbb-train-wagon after CSS refactoring |
There was a problem hiding this comment.
Probably move to global CSS with the CSS refactoring, as we don't want to repeat these SVGs in each SSR rendered component
| } | ||
| </${unsafeStatic(TAG_NAME)}> | ||
| `; | ||
| const typeLabel = (): string => { |
There was a problem hiding this comment.
Nitpick; Could probably be extracted into a private method?
github-actions
bot
added
the
pr: lead review approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2681
BREAKING CHANGE: The
hide-wagen-labelproperty of thesbb-train-formationwas removed. Now it automatically doesn't show the label if no label is set on all the wagons.The i18n
i18nClosedCompartmentLabel()method doesn't takewagonNumberas an argument anymore but is a constant now.Additionally, there are some visual changes:
sbb-train-wagon: Theouccpancyproperty doesn't default tononeanymore but tonull. Please replace the currently undefined occupancy property with the valuenone.sbb-train-wagon: Previously for the locomotive the label was not displayed, but now it would, as soon as there is one providedsbb-train-formation: The inline padding (left / right) was removed but can be set by CSS variable. See documentation.