Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using modules sarama from Spotify to IBM name #248

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Ales999
Copy link

@Ales999 Ales999 commented Dec 29, 2024

Upgrade using renamed repo github.com/Shopify/sarama v1.27.0 to github.com/IBM/sarama v1.44.0
Please test work Kafka before accepting this PR.

@sbezverk
Copy link
Owner

@Ales999 Thank you for your PR, any particular reason to move to go 1.23?

@Ales999
Copy link
Author

Ales999 commented Jan 20, 2025

One external module, requests version go 1.22 :
https://github.com/nats-io/nats.go/blob/807fe5be1065b81b88dcb61475f3338199adb2f6/go.mod#L3

Apparently many people think this is a good idea, and I switched back to using 1.22 instead of 1.23.

@Ales999 Ales999 marked this pull request as ready for review January 20, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants