-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libmediainfo.so to library_paths for Linux (actually Termux) #134
base: master
Are you sure you want to change the base?
Conversation
Thanks, I'll fix the CI and I'll look into this. Any idea why Termux does this whereas other distributions ? On Gentoo and Arch Linux, it looks like this:
|
Thanks for the help! Actually I'm not sure, but perhaps to save a tiny bit of space? On my phone,
|
I think I found the QA issue: can you please cherry-pick d02fb74 and push again? |
The tuple is not of a fixed length.
I add an explicit type annotation to |
Hello @valpogus, I see you've committed to https://github.com/termux/termux-packages/commits/master/packages/libmediainfo/build.sh quite a bit. Could you please tell me why there is no |
Oh yeah indeed. It took me a while to understand what was happening so I added a long comment in 2a4650e. I will push it as soon as I check that the CI works with it. |
Actually, I don't know :). When I first created the mediainfo packages, I also created the soversion-suffixed symlinks mirroring the official DEB packages to be compatible with pymediainfo (see termux/termux-packages#4642). The soversion-suffixed symlinks were later removed on commit termux/termux-packages@bc1264e. Maybe the commiter @xtkoba can provide a reason why. Otherwise, https://gitter.im/termux/dev might be a good place to ask. I am far from an expert on these matters. |
The libmediainfo package of Termux uses
libmediainfo.so
rather thanlibmediainfo.so.0
.