Add pre commit with ruff #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getzze
commented
Feb 13, 2025
| @@ -163,15 +163,12 @@ def __eq__(self, other: object) -> bool: | |||
| return self.tracks == other.tracks | |||
|
|
|||
| def __init__(self, xml: str, encoding_errors: str = "strict") -> None: | |||
| xml_dom = ET.fromstring(xml.encode("utf-8", encoding_errors)) | |||
| xml_dom = ET.fromstring(xml.encode("utf-8", encoding_errors)) # noqa: S314 | |||
There was a problem hiding this comment.
ruff recommendation is to use the defusedxml module instead of the stdlib because it corrects several vulnerabilities.
But it would add a dependency to the project.
|
the CI is failing on the scripts that I didn't clean on purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace isort, black, pylint, flake8 by
ruff.Add
typosto correct for misspelled words.Then use
pre-committo start the linter.pre-commitcan be installed locally, so the linter is run before every commit to ensure the code is always clean.I also added two changes that were mentioned in other issues:
setuptools_scmdependency in the docs and useimportlib.metadata_normalize_filenamestatic method to usedos.fspathinstead. Also remove the tests associated to it.src/pymediainfo/__init__.pyare ruff recommendations.(ruff still shows errors in
scripts/download_library.pythat I didn't correct because it would conflict with the changes of PR #144)