Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDDLPlusGPLClasspath to LicenseCategory.all #131

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

haveo
Copy link

@haveo haveo commented Oct 10, 2024

Because this object was missing from LicenseCategory.all dependencies with that license were not parsed correctly.

As an aside, is there an explicit policy for what licenses can be included in the default allowlist? It seems most weak copyleft licenses are not included with the exception of EPL and Mozilla. I personally can't think of a usecase where simply pulling a weak copyleft dependency would be problematic.

@eed3si9n
Copy link
Member

As an aside, is there an explicit policy for what licenses can be included in the default allowlist?

If people want to discuss this, it should be a separate https://github.com/sbt/sbt-license-report/discussions/ topic, not a side show on a pull request.

@mkurz
Copy link
Member

mkurz commented Oct 23, 2024

@eed3si9n Discussions are not enabled in this repo.

@eed3si9n
Copy link
Member

Enabled it.

@eed3si9n eed3si9n merged commit ad5c71c into sbt:main Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants