sbt-license-report-31 Add a link to the homepage of a dependency. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasRouquette
commented
Aug 28, 2016
NicolasRouquette
commented
- bumped sbt version to 0.13.12
- implemented Add a link to the homepage of a dependency. #31 as described
- bumped sbt version to 0.13.12 - implemented sbt#31 as described
|
Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
I signed the Lightbend / Typesafe CLA with approval from JPL/Caltech. |
benmccann
reviewed
Nov 13, 2017
| @@ -7,11 +7,11 @@ excludeDependencies += SbtExclusionRule(organization = "org.scala-lang") | |||
|
|
|||
| TaskKey[Unit]("check") := { | |||
| val contents = sbt.IO.read(target.value / "license-reports" / "example-licenses.md") | |||
| if (!contents.contains("[The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | com.fasterxml.jackson.core # jackson-databind # 2.5.4")) | |||
There was a problem hiding this comment.
do you have to change this from databind to core? I believe that databind was chosen specifically for this test
|
This PR will need to be rebased. It would probably be nice to separate the formatting cleanup and SBT upgrade from the implementation of a new feature into separate PRs |
|
Closing due to inactivity. Please feel free to reopen after rebasing and addressing the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.