Add license check #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sbt tasks that allow to check whether any dependency uses a license that is not within an allowed set of license categories. This is helpful for corporate environments where only certain licenses may be used.
eed3si9n
reviewed
Jul 25, 2023
| @@ -36,6 +36,7 @@ object SbtLicenseReport extends AutoPlugin { | |||
| val dumpLicenseReportAnyProject = taskKey[File]( | |||
| "Dumps a report file against all projects of the license report (using the target language) and combines it into a single file." | |||
| ) | |||
| val checkLicenses = taskKey[Unit]("Checks that all licenses are allowed. Fails if other licenses are found.") | |||
There was a problem hiding this comment.
updateLicenses flaunts it, but generally I think we should try to name tasks with "plugin-specific-prefix + something", so I think licenseCheck is better, like scalafmtCheck
There was a problem hiding this comment.
All tasks in this plugin are named "verb + noun", so this adds inconsistency, but I agree with your reasoning in general and renamed.
mkurz
reviewed
Oct 12, 2024
| LicenseCategory.MIT, | ||
| LicenseCategory.Mozilla, | ||
| LicenseCategory.PublicDomain | ||
| ) |
There was a problem hiding this comment.
Why was the LGPL category not added to this list? AFAIK, it is allowed to ship libraries licensed under the LGPL with proprietary software.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sbt tasks that allow to check whether any dependency uses a license that is not within an allowed set of license categories. This is helpful for corporate environments where only certain licenses may be used. The tasks behave similar to check tasks of other set plugins, for example
scalafmtCheckAll.