Fix CDDL + GPL with classpath LicenseCategory #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
fix-cddl-gplv2
branch
from
3b778f7
to
8d43055
Compare
eed3si9n
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an existing license. For starters the
LicenseCategoryits currently using is incorrect/misleading since it just points toCDDLinstead ofCDDL + GPL with classpath exception. Furthermore the current"CDDL + GPLv2 License"name is missing the "classpath exception" part, this missing of "classpath exception" is likely an oversight since this is a very bespoke license that is used for JVMjavax/glassfishlibraries (and all of these libraries have the classpath exception since its on the JVM). And finally the URI thathttps://glassfish.dev.java.net/nonav/public/CDDL+GPL.htmlpoints to isn't even loading so this has been fixed.If you want an example of a recently released library that has such a license look at
<licenses>in https://repo1.maven.org/maven2/javax/servlet/javax.servlet-api/4.0.1/javax.servlet-api-4.0.1.pom, the data for this PR was taken from that.