feat: implement basic Alchemist incarnation for scafi3 #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 69.40% 68.14% -1.26%
==========================================
Files 40 40
Lines 487 496 +9
Branches 40 46 +6
==========================================
Hits 338 338
- Misses 149 158 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @nicolasfara! 👋 |
nicolasfara
force-pushed
the
feat/incarnation
branch
from
e8d74d3 to
6e82400
Compare
cric96
requested changes
Oct 10, 2025
alchemist-incarnation-scafi3/src/main/scala/it/unibo/alchemist/Scafi3Incarnation.scala
Outdated
Show resolved
Hide resolved
alchemist-incarnation-scafi3/src/main/scala/it/unibo/alchemist/actions/RunScafi3Program.scala
Outdated
Show resolved
Hide resolved
...3/src/main/scala/it/unibo/scafi/alchemist/device/sensors/AlchemistEnvironmentVariables.scala
Outdated
Show resolved
Hide resolved
| def gradient(using Lang): Double = | ||
| share(Double.MaxValue): prevValues => | ||
| val distances = senseDistance[Double] | ||
| val minDistance = prevValues.alignedMap(distances)(_ + _).withoutSelf.min |
There was a problem hiding this comment.
Shall we implement some basic operators? Like +, -, etc via type classes?
There was a problem hiding this comment.
You mean basic operators over ShareData[T] (aka Field)?
nicolasfara
force-pushed
the
feat/incarnation
branch
2 times, most recently
from
aa77201 to
821b061
Compare
nicolasfara
force-pushed
the
feat/incarnation
branch
from
821b061 to
aca74dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a basic Alchemist incarnation supporting scafi3