Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the Governance page readable straight through #1705

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Oct 21, 2024

this is a sequel to #1700

@tgodzik told me in conversation that he is open to a plain-text look instead of the cards

I think the cards made sense when they were at the top of https://www.scala-lang.org/community/ and it was important not to use too much vertical real estate

but now I think it's merely annoying to have click through all the cards in order to read everything

also, having everything in cards meant the page had no proper table of contents

in putting this PR together, I tried to avoid changing the text, but I did do some light editing/rearranging to reduce redundancy between the "Who's behind Scala?" sections and the other sections, to make the page make better sense as a single whole

@SethTisue
Copy link
Member Author

SethTisue commented Oct 21, 2024

the old look is currently still viewable at https://www.scala-lang.org/governance/

and here are screen shots showing the plain-text look I'm suggesting. (UPDATE: the texts have changed a bit since these screen shots, so please use the diffs to review the actual texts)

Screenshot 2024-10-21 at 1 00 02 PM Screenshot 2024-10-21 at 1 00 06 PM

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't have any particular preferences, but I guess plain text is easier to notice. Although, should we have a summary of all the links user might want to use? Isn't it too hidden in text now?

@tgodzik tgodzik requested a review from Gedochao October 22, 2024 10:33
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

governance/index.md Outdated Show resolved Hide resolved
Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com>
@SethTisue
Copy link
Member Author

Although, should we have a summary of all the links user might want to use? Isn't it too hidden in text now?

Hmm.... I'm not entirely sure what you mean. Or I sort of know, but I'm not really sure what a fix would look like. I guess I'll just merge this and then we can consider further changes; maybe you'd like to send a small followup PR on this...?

@SethTisue SethTisue merged commit 726874f into scala:main Oct 22, 2024
1 check passed
@SethTisue SethTisue deleted the more-readable-governance-page branch October 22, 2024 13:53
@tgodzik
Copy link
Contributor

tgodzik commented Oct 22, 2024

maybe you'd like to send a small followup PR on this...?

Maybe it's enough, though if at some point I have some unexpected strike of UX genius I will do a follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants