Don't show extra applies for non-type-forwarder vals

scala · Apr 12, 2024 · bc7c848 · bc7c848
1 parent adde393
commit bc7c848
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala b/presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala
@@ -238,7 +238,9 @@ class Completions(
           .filter(_.symbol.isAccessibleFrom(denot.info))
         constructors -> true
 
-      else if shouldAddSnippet && completionMode.is(Mode.Term) && sym.name.isTermName && !sym.is(Flags.Method) && !sym.is(Flags.JavaDefined) then
+      else if shouldAddSnippet && completionMode.is(Mode.Term) && sym.name.isTermName &&
+          !sym.is(Flags.JavaDefined) && (sym.isClass || sym.is(Module) || (sym.isField && denot.info.isInstanceOf[TermRef])) then
+
         val constructors = if sym.isAllOf(ConstructorProxyModule) then
           sym.companionClass.info.member(nme.CONSTRUCTOR).allSymbols
         else

diff --git a/presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionDocSuite.scala b/presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionDocSuite.scala
@@ -305,7 +305,6 @@ class CompletionDocSuite extends BaseCompletionSuite:
         |  }
         |}
       """.stripMargin,
-      """|myNumbers(i: Int): Int
-         |myNumbers: Vector[Int]
+      """|myNumbers: Vector[Int]
          |""".stripMargin
     )
diff --git a/presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionSuite.scala b/presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionSuite.scala
@@ -1627,8 +1627,7 @@ class CompletionSuite extends BaseCompletionSuite:
          |  val fooBar = List(123)
          |  foo@@
          |""".stripMargin,
-      """|fooBar(n: Int): Int
-         |fooBar: List[Int]
+      """|fooBar: List[Int]
          |""".stripMargin
     )
 

diff --git a/presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionWorkspaceSuite.scala b/presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionWorkspaceSuite.scala
@@ -810,7 +810,6 @@ class CompletionWorkspaceSuite extends BaseCompletionSuite:
          |}
          |""".stripMargin,
       """|fooBar: String
-         |fooBar(n: Int): Int - test.A
          |fooBar: List[Int]
          |""".stripMargin,
     )