-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quote ASTs to TASTy #20165
Add quote ASTs to TASTy #20165
Conversation
3e782e9
to
4b7da46
Compare
e12cb19
to
f7063f0
Compare
@WojciechMazur could you test this PR on the open community build? |
The OpenCB was started, I'll post the result tomorrow when it's done |
We have 4 projects that started to fail after this change. In most cases it seems like the typer issue, eg. Error: | Found: Int => String
Error: | Required: T => Any
|
// TODO: Handle `targs` for #18271. We should be able to pickle the | ||
// `targs ::: args` if we add an `EXPLICITtpt` to the targs. | ||
// See comment in SPLICEPATTERN unpickling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this TODO need to be addressed now? If not, how can we do it backward-compatibly in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I previously thought that we could do it in a backward-compatible way, but now I see that my strategy will not work. I will propose another solution that will be future-proof for #18271.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually my original idea will work. I replaced the comments with a partial implementation.
I fixed these with the change in 3f2db24. This also removed the changes in the checkfiles (these where suspicious). |
Add AST nodes for Quote, Splice, QuotePattern, and QuoteSplice to TASTy.
These types where encoded explicitly before in the type parameter of the `runtime.Expr.{expr,splice,nestedSplice}` methods. We still need them.
3f2db24
to
31fe897
Compare
Future proof for scala#18271.
3d8aca6
to
743cc0b
Compare
This has been decided to be included in the 3.5.0 release. |
Add AST nodes for
Quote
,Splice
,QuotePattern
, andQuoteSplice
to TASTy.