Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow as as an infix type in non context bound types #21849

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix: Allow as as an infix type in non context bound types #21849

merged 2 commits into from
Nov 4, 2024

Conversation

KacperFKorban
Copy link
Member

potential fix for #21769

@KacperFKorban KacperFKorban marked this pull request as ready for review October 29, 2024 08:34
@KacperFKorban KacperFKorban linked an issue Oct 29, 2024 that may be closed by this pull request
Regression in parser for usage of user defined inflix trait as #21769
Closed
odersky
odersky reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just use a Boolean for inContextBound. Our convention is that we pass all Boolean arguments as named parameters. That takes care of the readability issue.

odersky
odersky requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@odersky odersky merged commit aa60a39 into scala:main Nov 4, 2024
29 checks passed
@odersky odersky deleted the fix-i21769 branch November 4, 2024 14:31
@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 6, 2024
@WojciechMazur WojciechMazur mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in parser for usage of user defined inflix trait as
3 participants
@KacperFKorban @odersky @WojciechMazur