Add missing error messages to asserts in QuotesImpl #21852
Merged
+42
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchyb
reviewed
Oct 31, 2024
There was a problem hiding this comment.
The changes itself LGTM! Just found the smallest typo. I do have one concern for the tests though... we have two of these already, and the visible stack trace makes it require regenerating check files with every change to QuotesImpl.scala (I do intend to adjust those, one day...). Perhaps we could catch the assertion error in the macro, check the message, rethrow it, and not have a checkfile here?
|
Right! I didn't think about the fact that the whole stack trace is very implementation dependent. Looks a bit hacky now, but works. Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20946