Fix regression #23969: Add ensureApplied to the quotes reflect API #24160
+39
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchyb
changed the title
jchyb
force-pushed
the
fix-i23969
branch
2 times, most recently
from
5a6580c to
2f0d636
Compare
hamzaremmal
reviewed
Oct 27, 2025
Comment on lines
+5
to
+6
| def a1 = () | ||
| def a2() = () |
There was a problem hiding this comment.
I'm curious about what will happen if we do this?
Suggested change
| def a1 = () | |
| def a2() = () | |
| def a1[T] = () | |
| def a2[T]() = () |
At least, we should include them in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23969
The regression would not appear on main (only after release on the nightly version of the compiler, as explained here), so I've adjusted the test to be more general.