Don't add cap when creating instances of capability classes. #24256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses To make up for this, refine the scheme to determine an implied fresh cap from the class fields.
odersky
changed the title
bracevac
approved these changes
Oct 27, 2025
| then | ||
| if ref.captureSetOfInfo.elems.isEmpty then | ||
| val deepStr = if ref.isReach then " deep" else "" | ||
| report.error(em"$ref cannot be tracked since its$deepStr capture set is empty", pos) |
There was a problem hiding this comment.
Suggested change
| report.error(em"$ref cannot be tracked since its$deepStr capture set is empty", pos) | |
| report.error(em"$ref cannot be tracked since its $deepStr capture set is empty", pos) |
There was a problem hiding this comment.
no that would add an extra space in front of deep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't automatically add cap when creating instances of capability classes.
To make up for this, refine the scheme to determine an implied fresh cap from
the class fields.
Also: Fix spurious warnings about redundant capabilities.