Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix buffer_bbox offset #1209

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix buffer_bbox offset #1209

wants to merge 3 commits into from
+3 −1

Conversation

MatthisCl
Copy link
Contributor

@MatthisCl MatthisCl commented Nov 7, 2024 •
edited
Loading

Description:

  • Upsampling doesn't work as soon as the buffer in the upsample_cube_job needs to write more than once. Problem was a wrong offset calculation to determine position in the file buffer to write the data to.
  • Added new assertion to test_upsampling, which now checks if the mean of the data in both layers is the same.

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Added / Updated Tests

@MatthisCl MatthisCl marked this pull request as ready for review November 13, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbader markbader Awaiting requested review from markbader

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MatthisCl