bugfix: add class compatibility with java 8 #2554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JniGetWinDirs.java ends up being compiled jdk17 causing issues for jdk8 users.
|
@tgodzik mind taking a look at this? |
tgodzik
reviewed
Jan 7, 2025
| @@ -208,6 +208,7 @@ lazy val frontend: Project = project | |||
| lazy val cliSettings = Seq( | |||
| name := "bloop-cli", | |||
| scalaVersion := Dependencies.Scala213Version, | |||
| javacOptions ++= javacOpts, | |||
There was a problem hiding this comment.
cli module is published as a Native Image, so this should not be an issue.
Also, currently Bloop uses UnixDomainSocketAddress which was added in JDK 16, so Bloop can't really run on earlier JDKs (we would need to do some work on that), but we do automatically add release flags, which should work with most common issues
There was a problem hiding this comment.
Might be useful to add java 8 compatibility for folks who are only cleared to use the jar at work and not the native image (such as myself).
There was a problem hiding this comment.
Sure, but unfortunately Bloop will not currently work on earlier JDKs as it requires API from JDK 16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JniGetWinDirs.java ends up being compiled jdk17 (class file version 61.0) causing issues for jdk8 windows users.
This change adds source and target compatibility for bloop-cli with java 8.
JniGetWinDirs seems to have to been recently added as of 2.0.0