Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI step to compile benchmark code #860

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

bwignall
Copy link
Contributor

@bwignall bwignall commented Jul 2, 2024

First step suggested in #859 .

@bwignall
Copy link
Contributor Author

bwignall commented Jul 2, 2024

Is breeze.math.SparseOptimizationSpaceTest_Double known to be a flaky test? It repeatedly passes locally, and this PR shouldn't touch it.

@dlwh dlwh merged commit 39542c3 into scalanlp:master Jul 8, 2024
1 check passed
@dlwh
Copy link
Member

dlwh commented Jul 8, 2024

yeah a bunch of the tests are flaky. I've spent a bunhc of time getting them under control, but scalacheck didn't allow for seeding the RNG last I checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants