Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: run current version, parameters, profiling, structured results #1658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ak0rz
Copy link
Contributor

@ak0rz ak0rz commented Mar 10, 2024

Background

I'm going to introduce numerous changes related to performance of scalapb, but I noticed that existing suite is outdated and using template-based codegen to build suites. Also, I noticed that present results are incomparable because there was no platform information in result structure.

Solution

First, I've made a small local plugin that handles all dependencies for benchmark projects, allowing using either scalapb built from current sources or downloaded from remote ivy repo.
Second, I performed refactoring of suites so they would be actual benchmark classes, possibly annotated with @State and having @Param parameters. Thus added ability to test repeated field with various number of elements.
And lastly, I've made a custom JMH runner to be able to separate results for each benchmark in its own directory + put there profiling information too.

Pro-tip for review

Filter out all .html and .json files that was generated as a result of benchmark runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant