Skip to content

[scalardb-cluster] Make Envoy optional #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[scalardb-cluster] Make Envoy optional #302

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf108de
[scalardb-cluster] Make Envoy optional
kota2and3kan Jul 1, 2025
3ab9b21
Remain headless service for scalar admin
kota2and3kan Sep 12, 2025
b8d2a83
Update service.yaml
kota2and3kan Sep 12, 2025
5a4fe38
Add "-" for nindent to remove unneccesary new line
kota2and3kan Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions charts/scalardb-cluster/templates/scalardb-cluster/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,42 @@
{{- if not .Values.envoy.enabled }}
apiVersion: v1
kind: Service
metadata:
name: {{ include "scalardb-cluster.fullname" . }}-headless
name: {{ include "scalardb-cluster.fullname" . }}-endpoint
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a newly added service resource to provide the endpoint to access ScalarDB Cluster directly without Envoy.

namespace: {{ .Release.Namespace }}
labels:
{{- include "scalardb-cluster.labels" . | nindent 4 }}
annotations:
{{- toYaml .Values.scalardbCluster.service.annotations | nindent 4 }}
spec:
type: {{ .Values.scalardbCluster.service.type }}
sessionAffinity: None
ports:
{{- range $key, $value := .Values.scalardbCluster.service.ports }}
- name: {{ $key }}
{{- toYaml $value | nindent 6 }}
{{- end }}
selector:
{{- include "scalardb-cluster.selectorLabels" . | nindent 4 }}
{{- end }}
---
apiVersion: v1
kind: Service
metadata:
name: {{ include "scalardb-cluster.fullname" . }}-headless
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This headless service is used not only for the service discovery of Envoy but also for pod detection of Scalar Admin for Kubernetes. Therefore, we need to deploy this headless service always, even if we don't deploy Envoy.

namespace: {{ .Release.Namespace }}
labels:
{{- include "scalardb-cluster.labels" . | nindent 4 }}
annotations:
{{- toYaml .Values.scalardbCluster.service.annotations | nindent 4 }}
spec:
type: ClusterIP
clusterIP: None
sessionAffinity: None
ports:
{{- range $key, $value := .Values.scalardbCluster.service.ports }}
- name: {{ $key }}
{{ toYaml $value | indent 6 }}
{{- toYaml $value | nindent 6 }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a minor refactoring. This does not change any behaviors.

{{- end }}
selector:
{{- include "scalardb-cluster.selectorLabels" . | nindent 4 }}
Expand Down