changed host flag to be 0.0.0.0 to be compatible with both ipv4 and ipv6 #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andytang-scale can you test if the latest main branch works? In theory "::" should support ipv4 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This IPv6 host flag is blocking my K8s cluster istio proxy from successfully completing a health check against the model endpoint. This in turn prevents my request from getting routed from the model-engine gateway to the endpoint since there is application logic blocking this. I am told the
0.0.0.0address works for both IPv4 and IPv6 but do not have an environment to test on IPv6Test Plan and Usage Guide
I have tested this in an image running on a K8s cluster in our federal staging environment.