Merged
Conversation
226279a to
20a7bc8
Compare
20a7bc8 to
186f18e
Compare
Collaborator
michaelbishoff
left a comment
There was a problem hiding this comment.
I forget why this file is commented out, but can we add some tests here that use only the v2 APIs. The tests ensure that the generated client is valid (we saw an edge case where oneOf properties in the openapi.yaml file didn't generate correctly)
https://github.com/scaleapi/scaleapi-python-client/blob/master/tests/test_v2_client.py
dc87fa2 to
a17b1bb
Compare
Contributor
Author
|
Unable to create a chat project with template variables in the test SDK environment, so there are no tests for task creation and fetching. The test API key I use doesn't associate with the projects under my account. |
michaelbishoff
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How did you test your code?
Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.
tests/for the newly implemented methodstests/to cover changes made to existing methodsChecklist
Please make sure all items in this checklist have been fulfilled before sending your PR out for review!
_version.py(unless this PR only updates the documentation).