[SK-1024] Organization Custom Roles #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jranaskit
reviewed
Dec 13, 2024
scalekit/role.py
Outdated
|
|
||
| def __init__(self, core_client: CoreClient): | ||
| """ | ||
| Initializer for Organization Client |
There was a problem hiding this comment.
please update this doc string.
scalekit/role.py
Outdated
| self, organization_id: str, role_id: str | ||
| ) -> UpdateOrganizationRoleResponse: | ||
| """ | ||
| Method to update organization based on given data |
There was a problem hiding this comment.
Please update doc string to match method func.
scalekit/role.py
Outdated
| self, organization_id: str, role_id: str | ||
| ) -> GetOrganizationRoleResponse: | ||
| """ | ||
| Method to update organization based on given data |
There was a problem hiding this comment.
Please update doc string and doc params to match method def and func
scalekit/utils/directory.py
Outdated
| GROUPS_FIELD_NUMBER: _ClassVar[int] | ||
| USER_DETAIL_FIELD_NUMBER: _ClassVar[int] | ||
| id: str | None | ||
| id: Optional[str] |
There was a problem hiding this comment.
Let's not change it to older pythonic way. Please revert to original.
jranaskit
requested changes
Dec 13, 2024
scalekit/role.py
Outdated
|
|
||
|
|
||
| class RoleClient: | ||
| """Class definition for Organization Client""" |
There was a problem hiding this comment.
Please update this doc string too, check if there are any other which are not matching function/class definitions.
scalekit/utils/directory.py
Outdated
| from google.protobuf.internal import containers as _containers | ||
| from typing import ClassVar as _ClassVar, Iterable as _Iterable, Mapping as _Mapping, Optional as _Optional, \ | ||
| Union as _Union | ||
| Union as _Union, Optional |
There was a problem hiding this comment.
please remove unused imports.
jranaskit
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.