test(container): add tests for update #5072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
reviewed
Oct 23, 2025
|
|
||
| func createContainerWithImage(metaKey string, registryImageMetaKey string) core.BeforeFunc { | ||
| return core.ExecStoreBeforeCmd(metaKey, fmt.Sprintf( | ||
| "scw container container create namespace-id={{ .ContainerNamespace.ID }} name=%s registry-image={{ (index .%s 0).FullName }}:latest port=80 deploy=true -w", |
There was a problem hiding this comment.
Would it be possible to have registry image passed as a key?
There was a problem hiding this comment.
In the current implementation, I have modified the StoreImageInMeta function to have enough checks and to make sure that the full identifier for the image is stored in the Meta. Therefore, when the template is rendered here, we can be certain that the value is correct.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5072 +/- ##
==========================================
- Coverage 57.44% 57.43% -0.02%
==========================================
Files 307 308 +1
Lines 67083 67125 +42
==========================================
+ Hits 38535 38551 +16
- Misses 27113 27140 +27
+ Partials 1435 1434 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mia-Cross
force-pushed
the
container_add_tests_for_update
branch
from
7a8bbf6 to
87c7bf2
Compare
github-actions
bot
added
the
registry
remyleone
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.