feat: add useInfiniteDataLoader #2282
Conversation
DorianMaliszewski
requested review from
johnrazeur,
vincentaudebert,
fabienhebert,
philibea and
alexandre-combemorel
🦋 Changeset detectedLatest commit: 6b32e34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2282 +/- ##
==========================================
+ Coverage 91.26% 91.62% +0.35%
==========================================
Files 47 49 +2
Lines 2371 2592 +221
Branches 104 118 +14
==========================================
+ Hits 2164 2375 +211
- Misses 196 203 +7
- Partials 11 14 +3 ☔ View full report in Codecov by Sentry. |
| useEffect( | ||
| () => () => { | ||
| requestRefs.current.forEach(request => request.removeObserver(() => null)) | ||
| }, | ||
| [], | ||
| ) |
| ErrorType extends Error, | ||
| ParamsType, | ||
| ParamsKey extends keyof ParamsType, | ||
| > = Omit<UseDataLoaderConfig<ResultType, ErrorType>, 'initialData'> & { |
There was a problem hiding this comment.
Should we remove polling ?
| req => req.status === StatusEnum.IDLE && !enabled, | ||
| ) | ||
|
|
||
| const reload = useCallback(async () => { |
There was a problem hiding this comment.
What happen when a page doesn't exists anymore ?
There was a problem hiding this comment.
data will be null/undefined/empty array and be filtered out when user get the data from the hook. May be if it doesnt fit some edge cases I can cont how many requests we have and try to get each one sequentially then by using getNextPage the hook can try to fill the same number of pages but if it cant it will not make useless calls ? 🤔
Implement useInfiniteDataLoader to handle Load More on our UI