Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tidy): clean up README and badges #72

Merged
merged 3 commits into from
Nov 9, 2023
Merged

chore(tidy): clean up README and badges #72

merged 3 commits into from
Nov 9, 2023

Conversation

Shillaker
Copy link
Contributor

@Shillaker Shillaker commented Nov 9, 2023

Summary

What's changed?

  • Fix paths in top-level package.json
  • Split examples into separate workflow (with its own badge 😎)
  • Fix tests badge which was broken in last PR
  • Add npm badge
  • Give workflows consistent names

Why do we need this?

  • Bad paths in top-level package.json broke imports
  • Badges were broken
  • Didn't have a link to the npm package
  • Workflows were named using relative paths to YAML

How have you tested it?

See branch version here: https://github.com/scaleway/serverless-functions-node/tree/readme-fix

Checklist

  • I have reviewed this myself
  • There is a unit test covering every change in this PR
  • I have updated the relevant documentation

package.json Show resolved Hide resolved
cyclimse
cyclimse previously approved these changes Nov 9, 2023
Bemilie
Bemilie previously approved these changes Nov 9, 2023
@Shillaker Shillaker dismissed stale reviews from Bemilie and cyclimse via 4f94905 November 9, 2023 15:05
@Shillaker Shillaker enabled auto-merge (squash) November 9, 2023 15:14
@Shillaker Shillaker merged commit 17e849c into main Nov 9, 2023
23 checks passed
@Shillaker Shillaker deleted the readme-fix branch November 9, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants