Skip to content

feat(RDB): implement RDB engine upgrade using MajorUpgradeWorkflow #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 28, 2025
Merged

feat(RDB): implement RDB engine upgrade using MajorUpgradeWorkflow #3408

merged 17 commits into from
Oct 28, 2025
+2,105 −11

Conversation

@jremy42
Copy link
Contributor

@jremy42 jremy42 commented Oct 16, 2025 •
edited
Loading

close #2870

@github-actions github-actions bot added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Oct 16, 2025
@jremy42 jremy42 force-pushed the feat/rdb-engine-upgrade-management branch from 9559018 to a9c1ef2 Compare October 16, 2025 04:28
@jremy42 jremy42 changed the title feat(RDB): implement RDB engine upgrade using MajorUpgradeWorkflow to mini… feat(RDB): implement RDB engine upgrade using MajorUpgradeWorkflow Oct 16, 2025
@jremy42 jremy42 force-pushed the feat/rdb-engine-upgrade-management branch from 7381af1 to 8e30940 Compare October 16, 2025 15:05
@jremy42 jremy42 force-pushed the feat/rdb-engine-upgrade-management branch from 176d87a to 70553e5 Compare October 17, 2025 07:49
@jremy42 jremy42 marked this pull request as ready for review October 17, 2025 08:23
@jremy42 jremy42 requested review from a team and remyleone as code owners October 17, 2025 08:23
estellesoulard
estellesoulard reviewed Oct 20, 2025
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.66%. Comparing base (97801bb) to head (0032d57).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/services/rdb/instance.go 0.00% 91 Missing ⚠️
internal/services/rdb/testfuncs/checks.go 0.00% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #3408      +/-   ##
=========================================
- Coverage    1.67%   1.66%   -0.01%     
=========================================
  Files         390     390              
  Lines       43077   43177     +100     
=========================================
- Hits          722     720       -2     
- Misses      42273   42374     +101     
- Partials       82      83       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 added this pull request to the merge queue Oct 28, 2025
Merged via the queue into master with commit f89b981 Oct 28, 2025
86 checks passed
@jremy42 jremy42 deleted the feat/rdb-engine-upgrade-management branch October 28, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estellesoulard estellesoulard estellesoulard approved these changes

@remyleone remyleone Awaiting requested review from remyleone remyleone is a code owner

Assignees

No one assigned

Labels

rdb Managed MySQL and PostgreSQL issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RDB improve update engine upgrade management

4 participants

@jremy42 @codecov-commenter @estellesoulard @remyleone