Skip to content

Improvement/Fixup on buckets creations#2371

Merged
bert-e merged 1 commit intodevelopment/8.2from
improvement/ARSN-492
May 21, 2025
Merged

Improvement/Fixup on buckets creations#2371
bert-e merged 1 commit intodevelopment/8.2from
improvement/ARSN-492

Conversation

@benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Apr 30, 2025

with the migration to typescript the bucket creation has been changed always passing the capabilities as undefined , which is now breaking s3utils as we’re not able to retrieve the capabilities in order to update them

Issue: ARSN-492

@bert-e
Copy link
Contributor

bert-e commented Apr 30, 2025

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 30, 2025

Incorrect fix version

The Fix Version/s in issue ARSN-492 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.14

Please check the Fix Version/s of ARSN-492, or the target
branch of this pull request.

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.29%. Comparing base (6f9f6ad) to head (a8070d0).
Report is 57 commits behind head on development/8.2.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.2    #2371      +/-   ##
===================================================
+ Coverage            70.05%   70.29%   +0.24%     
===================================================
  Files                  218      219       +1     
  Lines                17443    17528      +85     
  Branches              3605     3630      +25     
===================================================
+ Hits                 12219    12321     +102     
+ Misses                5220     5203      -17     
  Partials                 4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benzekrimaha benzekrimaha requested review from a user and francoisferrand and removed request for francoisferrand April 30, 2025 15:41
@bert-e
Copy link
Contributor

bert-e commented Apr 30, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-492 branch 4 times, most recently from 18f1c2f to 9f2d97f Compare May 6, 2025 08:01
@benzekrimaha benzekrimaha requested review from a user and francoisferrand May 6, 2025 08:01
@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-492 branch 2 times, most recently from fcea66d to 22a5462 Compare May 6, 2025 08:42
quotaMax: new Long(newBucketMD.quotaMax || '0'),
capabilities: undefined,
// We're passing the capabilities value here as it's used for testing purposes
capabilities: newBucketMD.capabilities as CapabilitiesMongoDB || undefined,
Copy link
Contributor

@francoisferrand francoisferrand May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is very weird:

  • newBucketMD is the "serializable" variant of bucketMD: if typing is needed, it should be done in BucketInfo.makeSerializable
  • adding the type in here will only affect this specific function, as payload is only used here
  • Passing bucketMD.capabilities to createBucket() is not just for testing: today, maybe we do not do it "in prod" and only do it in tests, but since it is part of bucketInfo it should be supported, like all other fields... → if a fix is needed, it is not just for tests...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually like for the quotaMax , here we don't really need the makeSerializable to make capabilities typed the way it's needed to be set in mongodb as it's only used here thus in the payload used to create the bucket

@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-492 branch from 49797af to 073daf4 Compare May 13, 2025 07:01
@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-492 branch 4 times, most recently from 0864ba7 to fe130d9 Compare May 20, 2025 14:42
@bert-e
Copy link
Contributor

bert-e commented May 20, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-492 branch from fe130d9 to 6916e51 Compare May 20, 2025 14:43
@scality scality deleted a comment from bert-e May 20, 2025
Copy link
Contributor

@francoisferrand francoisferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update the PR with proper title and description

@benzekrimaha benzekrimaha changed the title Improvement/arsn 492 Improvement/Fixup on buckets creations May 21, 2025
@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-492 branch from c3b30cf to c17ef38 Compare May 21, 2025 12:29
In some tests, we actually pass the capabilities value to the createBucket function, overriding it to undefined breaks the behavior.
This commit fixes that by passing the capabilities value to the createBucket function.
Issue: ARSN-492
@benzekrimaha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 21, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.2

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 21, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue ARSN-492.

Goodbye benzekrimaha.

@bert-e bert-e merged commit 79fb036 into development/8.2 May 21, 2025
7 checks passed
@bert-e bert-e deleted the improvement/ARSN-492 branch May 21, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants