Improvement/cldsrv 724 sur utapi tests #5950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-sur-utapi-tests
branch
from
548afab to
4d4e5f0
Compare
❌ 390 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 50 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-sur-utapi-tests
branch
4 times, most recently
from
fdd6e44 to
9844ffb
Compare
tests/sur/quota.js
Outdated
Comment on lines
800
to
802
| next => { | ||
| createBucket(bucket, false, next); | ||
| }, |
There was a problem hiding this comment.
Suggested change
| next => { | |
| createBucket(bucket, false, next); | |
| }, | |
| next => createBucket(bucket, false, next); |
Comment on lines
+807
to
+782
| assert.ifError(err); | ||
| return next(); |
There was a problem hiding this comment.
not related to your changes but a quick win could be to just call the next with the error, because an assert in a cb makes it harder to debug, and can even hide the error (as we crash)
tests/sur/quota.js
Outdated
Comment on lines
431
to
433
| // Log what headers we're sending | ||
| // eslint-disable-next-line no-console | ||
| console.log('Request headers after stripping:', Object.keys(args.request.headers)); |
There was a problem hiding this comment.
We can probably remove this console log
tests/sur/quota.js
Outdated
| }); | ||
|
|
||
| // Add middleware to strip ALL checksum headers | ||
| s3Client.middlewareStack.add( |
There was a problem hiding this comment.
Can we maybe add a comment to explain why we need this? And maybe a ticket number if that could be removed, so we just support the standard headers
tests/sur/quota.js
Outdated
Comment on lines
262
to
258
| .catch(err => { | ||
| callback(err); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| .catch(err => { | |
| callback(err); | |
| }); | |
| .catch(err => callback(err)); |
tests/sur/quota.js
Outdated
| if (!err && !s3Config.isQuotaInflightEnabled()) { | ||
| mockScuba.incrementBytesForBucket(bucket, parts * partSize); | ||
| if (!s3Config.isQuotaInflightEnabled()) { | ||
| mockScuba.incrementBytesForBucket(bucket, -(parts * partSize)); |
There was a problem hiding this comment.
i'm not sure to get why we increment the bytes before the call then we decrement them, is there any issue with the test?
tests/sur/quota.js
Outdated
Comment on lines
154
to
156
| .catch(err => { | ||
| cb(err); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| .catch(err => { | |
| cb(err); | |
| }); | |
| .catch(err => cb(err)); |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
DarkIsDude
requested changes
Oct 2, 2025
| emptyMany(bucketNames) { | ||
| const promises = bucketNames.map( | ||
| bucketName => this.empty(bucketName) | ||
| const promises = bucketNames.map( |
tests/sur/quota.js
Outdated
Comment on lines
154
to
156
| .catch(err => { | ||
| cb(err); | ||
| }); |
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-sur-utapi-tests
branch
3 times, most recently
from
3aa5ada to
61f8a03
Compare
As test files depend on these utilities, they needed to be adapted to match the sdk v3 requirements. Issue: CLDSRV-724
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-sur-utapi-tests
branch
2 times, most recently
from
5ff3711 to
1f24c59
Compare
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-sur-utapi-tests
branch
from
1f24c59 to
adb7ac5
Compare
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
williamlardier
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Some code style issues
When the code style comments from @DarkIsDude are addressed we should be good, so approving for my part
| return Promise.all(promises); | ||
| } | ||
|
|
||
Comment on lines
130
to
131
| .map(object => | ||
| this.s3.send(new DeleteObjectCommand({ |
There was a problem hiding this comment.
Suggested change
| .map(object => | |
| this.s3.send(new DeleteObjectCommand({ | |
| .map(object => this.s3.send(new DeleteObjectCommand({ |
Comment on lines
58
to
60
| .catch(err => { | ||
| throw err; | ||
| }); |
There was a problem hiding this comment.
You can remove the .catch here, if we just re-throw inside
Suggested change
| .catch(err => { | |
| throw err; | |
| }); |
package.json
Outdated
| }, | ||
| "homepage": "https://github.com/scality/S3#readme", | ||
| "dependencies": { | ||
| "@aws-sdk/client-s3": "^3.705.0", |
There was a problem hiding this comment.
Suggested change
| "@aws-sdk/client-s3": "^3.705.0", | |
| "@aws-sdk/client-s3": "^3.908.0", |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following reviewers are expecting changes from the author, or must review again: |
DarkIsDude
approved these changes
Oct 27, 2025
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: CLDSRV-724