Skip to content

Conversation

@benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Oct 23, 2025

Issue: CLDSRV-724

@codecov
Copy link

codecov bot commented Oct 23, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
7327 2 7325 0
View the top 3 failed test(s) by shortest run time
should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1::Requests to ip endpoint not in config With v4 signature should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1
Stack Traces | 0.002s run time
Expected values to be strictly equal:

undefined !== ''
should return error if pattern is invalid::Invalid regular expression searches should return error if pattern is invalid
Stack Traces | 0.003s run time
done() called multiple times in test <Invalid regular expression searches should return error if pattern is invalid> of file .../test/mdSearch/basicSearch.js; in addition, done() received error: InvalidArgument: Invalid sql where clause sent as search query
    at throwDefaultError (.../cloudserver/cloudserver/node_modules/@.../smithy-client/dist-cjs/index.js:288:22)
    at .../cloudserver/cloudserver/node_modules/@.../smithy-client/dist-cjs/index.js:297:9
    at de_CommandError (.../cloudserver/cloudserver/node_modules/@.../client-s3/dist-cjs/index.js:4868:20)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async .../cloudserver/cloudserver/node_modules/@aws-sdk/client-s3/node_modules/@.../middleware-serde/dist-cjs/index.js:8:24
    at async .../cloudserver/cloudserver/node_modules/@.../middleware-sdk-s3/dist-cjs/index.js:386:20
    at async .../cloudserver/cloudserver/node_modules/@aws-sdk/client-s3/node_modules/@.../middleware-retry/dist-cjs/index.js:254:46
    at async .../cloudserver/cloudserver/node_modules/@.../middleware-sdk-s3/dist-cjs/index.js:63:28
    at async .../cloudserver/cloudserver/node_modules/@.../middleware-sdk-s3/dist-cjs/index.js:90:20
    at async .../cloudserver/cloudserver/node_modules/@aws-sdk/client-s3/node_modules/@.../middleware-logger/dist-cjs/index.js:5:26
    at async makeRequest (.../mdSearch/utils/helpers.js:71:25) {
  '$fault': 'client',
  '$response': [HttpResponse],
  '$retryable': undefined,
  '$metadata': [Object],
  Code: 'InvalidArgument',
  Resource: '',
  RequestId: '35401846294caaaf671a'
}
should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1::Requests to ip endpoint not in config With default signature should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1
Stack Traces | 0.003s run time
Expected values to be strictly equal:

undefined !== ''
should fail if version id is invalid::PUT object with x-scal-s3-version-id header With v4 signature error handling validation (without cold storage location) should fail if version id is invalid
Stack Traces | 0.015s run time
Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:121:17)
+     at Socket.socketOnData (node:_http_client:558:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null
should fail if version id is invalid::PUT object with x-scal-s3-version-id header With default signature error handling validation (without cold storage location) should fail if version id is invalid
Stack Traces | 0.018s run time
Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:121:17)
+     at Socket.socketOnData (node:_http_client:558:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-legacy-related-functional-tests branch 3 times, most recently from 5b3a4ed to 67b5ecb Compare October 28, 2025 14:37
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-service-get-related-functional-tests branch 2 times, most recently from c3a4685 to adf47bd Compare October 28, 2025 15:58
This commit updates functional tests for 'get' service to ensure compatibility
with recent changes in the aws sdk.
Issue: CLDSRV-724
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-service-get-related-functional-tests branch from 72dd6ed to cd35cca Compare October 28, 2025 15:59
@benzekrimaha benzekrimaha marked this pull request as ready for review October 28, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants