Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-1621 stronger healthcheck against leaks of runner #582

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Apr 17, 2024

No description provided.

@tcarmet tcarmet requested a review from a team as a code owner April 17, 2024 22:21
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 86.11%. Comparing base (c0fa117) to head (e68b39f).
Report is 3 commits behind head on main.

Files Patch % Lines
runner_manager/backend/aws.py 25.00% 6 Missing ⚠️
runner_manager/backend/gcloud.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   85.86%   86.11%   +0.24%     
==========================================
  Files          31       31              
  Lines        1224     1246      +22     
==========================================
+ Hits         1051     1073      +22     
  Misses        173      173              
Flag Coverage Δ
api 66.69% <38.70%> (-0.14%) ⬇️
unit 71.42% <67.74%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet merged commit a8d6d33 into main Apr 18, 2024
12 checks passed
@tcarmet tcarmet deleted the feature/ensure-no-leak branch April 18, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants