Merged
Conversation
- Replaced `exec` with `execFile` in multiple utility files for better security and performance. - Updated error logging to use formatted strings for consistency and clarity. - Enhanced URL validation to restrict to internal hosts and prevent SSRF vulnerabilities. - Improved regex patterns for URL extraction to handle a wider range of valid URLs. - Suppressed specific exceptions with logging for better debugging without interrupting flow. - Cleaned up unused imports and optimized code structure for readability.
Signed-off-by: Alexander Alten <alo.alt@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed CodeQL warnings and critical, hardened the system, added logging and redaction of secrets, reworked the password reset.