used product link from metadataPool instead of getId for Adobe commerce #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zans-laksa @carinadues Please review the PR |
|
@aleksandrsm can you please do CR? |
aleksandrsm
reviewed
Sep 21, 2022
src/Model/Variant/Collection.php
Outdated
| @@ -255,7 +255,8 @@ protected function getChildCollectionMapAndList(): array { | |||
| $childProductsList = []; | |||
|
|
|||
| $parentIds = array_map(function ($product) { | |||
| return $product->getId(); | |||
| $linkField = $this->metadataPool->getMetadata(ProductInterface::class)->getLinkField(); | |||
There was a problem hiding this comment.
here and in other places: only load $linkField ones, there is no need to check it inside each array/foreach iteration, it will not change
There was a problem hiding this comment.
@aleksandrsm Updated the changes, please check
aleksandrsm
approved these changes
Sep 23, 2022
|
@NavaneethVijay Thank you! This will be added in an upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scandipwa/scandipwa#5194