test(button): refactor ghost variant tests to use beforeEach for page…

… navigation
scania-digital-design-system · Dec 12, 2024 · c4fcae6 · c4fcae6
1 parent d886813
commit c4fcae6
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 6 deletions.
diff --git a/packages/core/src/components/button/test/ghost/primary_darkmode/button.e2e.ts b/packages/core/src/components/button/test/ghost/primary_darkmode/button.e2e.ts
@@ -4,8 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/button/test/ghost/primary_darkmode/index.html';
 
 test.describe.parallel('tds-button-ghost-primary-darkmode', () => {
-  test('renders ghost button correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
+
+  test('renders ghost button correctly', async ({ page }) => {
     const button = page.getByTestId('tds-button-testid');
     await expect(button).toHaveCount(1);
 

diff --git a/packages/core/src/components/button/test/ghost/primary_lightmode/button.e2e.ts b/packages/core/src/components/button/test/ghost/primary_lightmode/button.e2e.ts
@@ -4,8 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/button/test/ghost/primary_lightmode/index.html';
 
 test.describe.parallel('tds-button-ghost-primary-lightmode', () => {
-  test('renders ghost button correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
+
+  test('renders ghost button correctly', async ({ page }) => {
     const button = page.getByTestId('tds-button-testid');
     await expect(button).toHaveCount(1);
 

diff --git a/packages/core/src/components/button/test/ghost/secondary_darkmode/button.e2e.ts b/packages/core/src/components/button/test/ghost/secondary_darkmode/button.e2e.ts
@@ -4,8 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/button/test/ghost/secondary_darkmode/index.html';
 
 test.describe.parallel('tds-button-ghost-secondary-darkmode', () => {
-  test('renders ghost button correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
+
+  test('renders ghost button correctly', async ({ page }) => {
     const button = page.getByTestId('tds-button-testid');
     await expect(button).toHaveCount(1);
 

diff --git a/packages/core/src/components/button/test/ghost/secondary_lightmode/button.e2e.ts b/packages/core/src/components/button/test/ghost/secondary_lightmode/button.e2e.ts
@@ -4,8 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/button/test/ghost/secondary_lightmode/index.html';
 
 test.describe.parallel('tds-button-ghost-secondary-lightmode', () => {
-  test('renders ghost button correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
+
+  test('renders ghost button correctly', async ({ page }) => {
     const button = page.getByTestId('tds-button-testid');
     await expect(button).toHaveCount(1);
 

diff --git a/packages/core/src/components/button/test/ghost/unspecified/button.e2e.ts b/packages/core/src/components/button/test/ghost/unspecified/button.e2e.ts
@@ -4,8 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/button/test/ghost/unspecified/index.html';
 
 test.describe.parallel('tds-button-ghost', () => {
-  test('renders ghost button correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
+
+  test('renders ghost button correctly', async ({ page }) => {
     const button = page.getByTestId('tds-button-testid');
     await expect(button).toHaveCount(1);
 
@@ -14,7 +17,6 @@ test.describe.parallel('tds-button-ghost', () => {
   });
 
   test('Check so that height is correct to md measurements', async ({ page }) => {
-    await page.goto(componentTestPath);
     const button = page.getByText('Button', { exact: true });
     const buttonHeight = await button.evaluate((style) => getComputedStyle(style).height);
     expect(buttonHeight).toBe('24px');