test(spinner): refactor tests to use beforeEach for page navigation

scania-digital-design-system · Dec 17, 2024 · ca417e0 · ca417e0
1 parent 4dcf97e
commit ca417e0
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/packages/core/src/components/spinner/test/inverted/darkmode/spinner.e2e.ts b/packages/core/src/components/spinner/test/inverted/darkmode/spinner.e2e.ts
@@ -4,9 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/spinner/test/inverted/darkmode/index.html';
 
 test.describe.parallel('tds-spinner-inverted-darkmode', () => {
-  test('renders inverted spinner correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
 
+  test('renders inverted spinner correctly', async ({ page }) => {
     /* Check diff on screenshot */
     await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
   });

diff --git a/packages/core/src/components/spinner/test/inverted/lightmode/spinner.e2e.ts b/packages/core/src/components/spinner/test/inverted/lightmode/spinner.e2e.ts
@@ -4,9 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/spinner/test/inverted/lightmode/index.html';
 
 test.describe.parallel('tds-spinner-inverted-lightmode', () => {
-  test('renders inverted spinner correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
 
+  test('renders inverted spinner correctly', async ({ page }) => {
     /* Check diff on screenshot */
     await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
   });

diff --git a/packages/core/src/components/spinner/test/standard/darkmode/spinner.e2e.ts b/packages/core/src/components/spinner/test/standard/darkmode/spinner.e2e.ts
@@ -4,9 +4,11 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/spinner/test/standard/darkmode/index.html';
 
 test.describe.parallel('tds-spinner-standard-darkmode', () => {
-  test('renders basic spinner correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
 
+  test('renders basic spinner correctly', async ({ page }) => {
     /* Check diff on screenshot */
     await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
   });

diff --git a/packages/core/src/components/spinner/test/standard/lightmode/spinner.e2e.ts b/packages/core/src/components/spinner/test/standard/lightmode/spinner.e2e.ts
@@ -4,16 +4,16 @@ import { expect } from '@playwright/test';
 const componentTestPath = 'src/components/spinner/test/standard/lightmode/index.html';
 
 test.describe.parallel('tds-spinner-standard-lightmode', () => {
-  test('renders basic spinner correctly', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     await page.goto(componentTestPath);
+  });
 
+  test('renders basic spinner correctly', async ({ page }) => {
     /* Check diff on screenshot */
     await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
   });
 
   test('Check if animation is present', async ({ page }) => {
-    await page.goto(componentTestPath);
-
     const spinner = page.locator('tds-spinner:first-child circle');
     const spinnerStyle = await spinner.evaluate((style) => getComputedStyle(style).animationName);
     expect(spinnerStyle).toBe('dash');