Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(node) bumped to 22.11.0 lts/jod #862

Merged
merged 4 commits into from
Jan 17, 2025
Merged

build(node) bumped to 22.11.0 lts/jod #862

merged 4 commits into from
Jan 17, 2025

Conversation

Lunkan89
Copy link
Collaborator

@Lunkan89 Lunkan89 commented Nov 26, 2024 •
edited by jira bot
Loading

Describe pull-request

Bumped to node 22.11.0 lts/jod

Issue Linking:

Choose one of the following options

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Fetch and checkout branch
  2. Install and run node 22.11.0 lts/jod nvm install lts/jod
  3. From root npm run reinstall && npm run build-all && npm run test

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

@aws-amplify-eu-north-1 AWS Amplify (eu-north-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-862.d3fazya28914g3.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Playwright test results

passed  420 passed
skipped  1 skipped

Details

stats  421 tests across 146 suites
duration  1 minute, 3 seconds
commit  b43c9a8

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@theJohnnyMe
Copy link
Contributor

Suggestion is to merge this PR after release. It would give us more time to adjust AWS services to use new version of node too and enough time to "play" with system on new Node version.

@theJohnnyMe theJohnnyMe changed the title fix: bumped to node 22.11.0 lts/jod build(node) bumped to 22.11.0 lts/jod Nov 26, 2024
@theJohnnyMe theJohnnyMe force-pushed the fix/CDEP-3556-node-22 branch from c50efd8 to 3fc721b Compare November 29, 2024 16:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

theJohnnyMe
theJohnnyMe approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, code builds and works as expected!
PS: I did a rebase with develop, push small update on smoke script as it had some conflicts + new lock files.

nathalielindqvist
nathalielindqvist approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@nathalielindqvist nathalielindqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 🌟

@Lunkan89 Lunkan89 force-pushed the fix/CDEP-3556-node-22 branch from c9b2fd8 to 503f980 Compare January 16, 2025 12:56
@theJohnnyMe theJohnnyMe force-pushed the fix/CDEP-3556-node-22 branch from 503f980 to b1f3b99 Compare January 16, 2025 15:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Lunkan89 Lunkan89 merged commit 775432e into develop Jan 17, 2025
4 checks passed
@Lunkan89 Lunkan89 deleted the fix/CDEP-3556-node-22 branch January 17, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathalielindqvist nathalielindqvist nathalielindqvist approved these changes

@theJohnnyMe theJohnnyMe theJohnnyMe approved these changes

@ckrook ckrook Awaiting requested review from ckrook ckrook is a code owner

@mistermalm mistermalm Awaiting requested review from mistermalm mistermalm is a code owner

@EmelieLitwin EmelieLitwin Awaiting requested review from EmelieLitwin EmelieLitwin is a code owner

@timrombergjakobsson timrombergjakobsson Awaiting requested review from timrombergjakobsson timrombergjakobsson is a code owner

Assignees

@Lunkan89 Lunkan89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lunkan89 @theJohnnyMe @nathalielindqvist