Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add motion to popover component #879

Closed
wants to merge 21 commits into from

Conversation

ckrook
Copy link
Collaborator

@ckrook ckrook commented Dec 9, 2024

Describe pull-request

This PR applies animation "fade" to the popover-core component. This will be reflected in the popover-canvas, popover-menu.
popover-tooltip already have an animation from before, it should work as as it use to work.

Issue Linking:

Choose one of the following options

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Navigate to the AWS link
  2. Go to popover-menu, popover-canvas & popover-tooltip
  3. Make sure that the controls for animation works.

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

popover-canvas-motion.mov
popover-menu-motion.mov

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Playwright test results

failed  1 failed
passed  417 passed
skipped  1 skipped

Details

stats  419 tests across 145 suites
duration  58.2 seconds
commit  494f10a

Failed tests

src/components/popover-menu/test/default/popover-menu.e2e.ts › tds-popover-menu-default › clicking the trigger button should open the popover menu dialog

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-879.d3fazya28914g3.amplifyapp.com

@ckrook ckrook closed this Dec 18, 2024
@ckrook ckrook deleted the feature/motion-popover branch December 18, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant