-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add motion to popover component #879
Conversation
Co-authored-by: Tim <tim.romberg@scania.com>
…digital-design-system/tegel into feature/motion-variables
Co-authored-by: Tim <tim.romberg@scania.com>
…digital-design-system/tegel into feature/motion-variables
Playwright test resultsDetails 419 tests across 145 suites Failed testssrc/components/popover-menu/test/default/popover-menu.e2e.ts › tds-popover-menu-default › clicking the trigger button should open the popover menu dialog Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Quality Gate passedIssues Measures |
Describe pull-request
This PR applies animation "fade" to the popover-core component. This will be reflected in the popover-canvas, popover-menu.
popover-tooltip already have an animation from before, it should work as as it use to work.
Issue Linking:
Choose one of the following options
How to test
Provide detailed steps for testing, including any necessary setup.
Checklist before submission
npm run build-all
without errorsSuggested test steps
Screenshots
popover-canvas-motion.mov
popover-menu-motion.mov