Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(accordion): add screenshot tests (outdated) #888

Closed
wants to merge 4 commits into from

Conversation

max-umain
Copy link
Collaborator

@max-umain max-umain commented Dec 11, 2024

Describe pull-request

Adds screenshot tests for accordion in light and dark modes, as well as with different background colors and primary and secondary mode variant.

Issue Linking:

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Run npm run test
  2. Visually inspect the files generated by the tests

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Not applicable

Additional context

I got a timeout error when I made the file structure like this:
src/components/accordion/test/basic/primary/lightmode/
So I changed it to be like this:
src/components/accordion/test/basic_primary/lightmode/

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-888.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Playwright test results

passed  400 passed
skipped  1 skipped

Details

stats  401 tests across 136 suites
duration  54.2 seconds
commit  de2fb02

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@max-umain max-umain self-assigned this Dec 11, 2024
@max-umain max-umain marked this pull request as draft December 11, 2024 20:48
@max-umain
Copy link
Collaborator Author

I just created a commit where I added back the original (from before the commits in this PR, the one that is now in the develop branch) "basic" test, now in "basic/unspecified"

@max-umain max-umain changed the title test(accordion): add screenshot tests test(accordion): add screenshot tests (outdated) Dec 12, 2024
@max-umain
Copy link
Collaborator Author

Replaced this PR with: #895

@max-umain max-umain closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant