Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(breadcrumbs): add darkmode screenshot test and refactor folder structure #890

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

max-umain
Copy link
Collaborator

@max-umain max-umain commented Dec 12, 2024

Describe pull-request

Adds screenshot tests for darkmode for breadcrumbs component.

Issue Linking:

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Run npm run test
  2. Visually inspect the files generated by the tests

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Not applicable

Additional context

None

@max-umain max-umain changed the title Test/breadcrumbs screenshot tests test(breadcrumbs) add screenshot tests Dec 12, 2024
@max-umain max-umain changed the title test(breadcrumbs) add screenshot tests test(breadcrumbs): add screenshot tests Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Playwright test results

passed  394 passed
skipped  1 skipped

Details

stats  395 tests across 133 suites
duration  54.5 seconds
commit  fc4b89a

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@max-umain max-umain marked this pull request as draft December 12, 2024 10:23
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-890.d3fazya28914g3.amplifyapp.com

@Lunkan89
Copy link
Collaborator

Amplify redeployed from AWS

@max-umain max-umain marked this pull request as ready for review December 12, 2024 14:11
@max-umain max-umain force-pushed the test/breadcrumbs-screenshot-tests branch from 5cb5e01 to fc4b89a Compare December 16, 2024 08:58
@max-umain max-umain changed the title test(breadcrumbs): add screenshot tests test(breadcrumbs): add darkmode screenshot test and refactor folder structure Dec 16, 2024
@ckrook ckrook merged commit 4b988e3 into develop Dec 16, 2024
4 checks passed
@ckrook ckrook deleted the test/breadcrumbs-screenshot-tests branch December 16, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants