Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(button): add primary variant darkmode and lightmode screenshot tests #892

Closed
wants to merge 5 commits into from
Closed

test(button): add primary variant darkmode and lightmode screenshot tests #892

wants to merge 5 commits into from

Conversation

max-umain
Copy link
Collaborator

@max-umain max-umain commented Dec 12, 2024 •
edited
Loading

Describe pull-request

Adds screenshot tests for button in primary and second mode variants for the primary variant.

Issue Linking:

How to test

  1. Run npm run test
  2. Visually inspect the files generated by the tests

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Not applicable

Additional context

None

@max-umain max-umain changed the title Test/button primary variant screenshot tests test(button): add primary variant screenshot tests Dec 12, 2024
@aws-amplify-eu-north-1 AWS Amplify (eu-north-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-892.d3fazya28914g3.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Playwright test results

passed  396 passed
skipped  1 skipped

Details

stats  397 tests across 136 suites
duration  52.8 seconds
commit  968766e

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@max-umain max-umain self-assigned this Dec 12, 2024
@max-umain max-umain force-pushed the test/button-primary-variant-screenshot-tests branch from 30123dd to 63e1e9e Compare December 12, 2024 14:48
@Lunkan89
Copy link
Collaborator

maybe put some padding in drakmode body for visual?

@max-umain
Copy link
Collaborator Author

max-umain commented Dec 12, 2024 •
edited
Loading

@Lunkan89
I'll add it to all of them, because 3 out of 4 of them have a background color, and these are all newly created tests that we haven't used before

@max-umain max-umain force-pushed the test/button-primary-variant-screenshot-tests branch from db5bc10 to 968766e Compare December 16, 2024 08:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@max-umain max-umain changed the title test(button): add primary variant screenshot tests test(button): add primary variant darkmode and lightmode screenshot tests Dec 16, 2024
@max-umain max-umain closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckrook ckrook ckrook approved these changes

@mistermalm mistermalm Awaiting requested review from mistermalm mistermalm is a code owner

@theJohnnyMe theJohnnyMe Awaiting requested review from theJohnnyMe theJohnnyMe is a code owner

@EmelieLitwin EmelieLitwin Awaiting requested review from EmelieLitwin EmelieLitwin is a code owner

@nathalielindqvist nathalielindqvist Awaiting requested review from nathalielindqvist nathalielindqvist is a code owner

@Lunkan89 Lunkan89 Awaiting requested review from Lunkan89 Lunkan89 is a code owner

@timrombergjakobsson timrombergjakobsson Awaiting requested review from timrombergjakobsson timrombergjakobsson is a code owner

Assignees

@max-umain max-umain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-umain @Lunkan89 @ckrook