Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding config var for consumers to set and choose url to assets #906

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

timrombergjakobsson
Copy link
Contributor

@timrombergjakobsson timrombergjakobsson commented Dec 13, 2024

Describe pull-request

Consuming applications want to be able to set a configurable to choose from where assets are loaded. I have made a beta release, here is the Angular 17 one for example https://www.npmjs.com/package/@scania/tegel-angular-17/v/1.21.1-config-for-china-beta.0

Problem Statement: Immutable CDN URL in Compiled CSS

Context:

  • In our Stencil.js package, we define a SASS variable $cdn: 'https://cdn.digitaldesign.scania.com' !default; for asset paths like fonts and logotypes.
  • This variable is used during the SASS compilation process to generate static @font-face declarations and other CSS rules in the final tegel.css file.
  • Consuming applications, such as those deployed in China, need to override the CDN URL (https://cdn.digitaldesign.scania.com) to use local assets (./assets) due to accessibility issues with the CDN.
    The Problem:
  • Static Compilation of CSS: Once the SASS is compiled into tegel.css, the $cdn variable is resolved to its value (https://cdn.digitaldesign.scania.com) during build time.
  • This hardcoded value becomes immutable in the compiled CSS and cannot be overridden by consuming applications at runtime.
  • Even if a consuming application sets a global variable like window.TEGEL_ASSET_SOURCE or a CSS custom property (--font-source), the paths in the precompiled tegel.css remain fixed and continue to point to the CDN.
    Symptoms:
  • Fonts and logotypes always load from the CDN, even when window.TEGEL_ASSET_SOURCE or runtime scripts try to change the source.
  • Consuming applications in China experience slow load times because the application waits for CDN requests to timeout before falling back.
    Underlying Cause:
  • The root issue is the static nature of the compiled CSS. SASS variables like $cdn are processed during the build phase of the library and cannot be altered dynamically in the final CSS.

Possible solutions:

Main idea in PR

  • Move all @font-face declarations from CSS files into JavaScript loader
  • Programmatic injection into document head
  • Dynamic control of asset source URL
  • All font URLs constructed using configurable assetSource

In connsuming applications the asset path can be oveeriden like this:

 <!-- Add this before loading Tegel components -->
   <script>
     window.TEGEL_ASSET_SOURCE = '/assets'; <--- place where assets has been copied over to after running `copy-assets`script
   </script>

Other possible solutions

  • Have some kind of performance monitoring that checks if cdn is respsonsive
  • If not continue with local fallback instead

Implementation benefits

  • No need to wait CDN timeouts
  • Automatic fallback to local assets
  • Can be configured with different timeout thresholds

Issue Linking:

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to...
  2. Check in...
  3. Run ...

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-906.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Playwright test results

failed  173 failed
passed  245 passed
skipped  1 skipped

Details

stats  419 tests across 145 suites
duration  2 minutes, 20 seconds
commit  6e9adc9

Failed tests

src/components/accordion/test/basic/accordion.e2e.ts › tds-accordion › renders basic accordion correctly
src/components/accordion/test/basic/accordion.e2e.ts › tds-accordion › second accordion item opens on click
src/components/accordion/test/hide-last-border/accordion.e2e.ts › tds-accordion › renders accordion with hidden last border correctly
src/components/badge/test/value/badge.e2e.ts › tds-badge › renders value badge correctly
src/components/banner/test/default/darkmode/banner.e2e.ts › tds-banner-default-darkmode › renders default banner correctly with darkmode
src/components/banner/test/default/lightmode/banner.e2e.ts › tds-banner-default-lightmode › renders default banner correctly
src/components/banner/test/error/darkmode/banner.e2e.ts › tds-banner-error-darkmode › renders error banner correctly with darkmode
src/components/banner/test/error/lightmode/banner.e2e.ts › tds-banner-error-lightmode › renders error banner correctly
src/components/banner/test/information/darkmode/banner.e2e.ts › tds-banner-information-darkmode › renders information banner correctly with darkmode
src/components/banner/test/information/lightmode/banner.e2e.ts › tds-banner-information-lightmode › renders information banner correctly
src/components/block/test/2-level-light-mode/block.e2e.ts › tds-block-2-level-light-mode › renders 2 level block correctly
src/components/block/test/3-level-dark-mode/block.e2e.ts › tds-block-3-level-dark-mode › renders 2 level block correctly
src/components/breadcrumbs/test/default/darkmode/breadcrumbs.e2e.ts › tds-breadcrumbs-default-darkmode › renders default breadcrumbs correctly
src/components/breadcrumbs/test/default/darkmode/breadcrumbs.e2e.ts › tds-breadcrumbs-default-darkmode › page 3 item should be able to become focused
src/components/breadcrumbs/test/default/lightmode/breadcrumbs.e2e.ts › tds-breadcrumbs-default-lightmode › renders default breadcrumbs correctly
src/components/breadcrumbs/test/default/lightmode/breadcrumbs.e2e.ts › tds-breadcrumbs-default-lightmode › page 3 item should be able to become focused
src/components/button/test/basic/button.e2e.ts › tds-button-basic › renders basic button correctly
src/components/button/test/danger/button.e2e.ts › tds-button-danger › renders danger button correctly
src/components/button/test/ghost/button.e2e.ts › tds-button-ghost › renders ghost button correctly
src/components/button/test/secondary/primary/darkmode/button.e2e.ts › tds-button-secondary-primary-darkmode › renders secondary button correctly
src/components/button/test/secondary/primary/lightmode/button.e2e.ts › tds-button-secondary-primary-lightmode › renders secondary button correctly
src/components/button/test/secondary/secondary/darkmode/button.e2e.ts › tds-button-secondary-secondary-darkmode › renders secondary button correctly
src/components/button/test/secondary/secondary/lightmode/button.e2e.ts › tds-button-secondary-secondary-lightmode › renders secondary button correctly
src/components/button/test/secondary/unspecified/button.e2e.ts › tds-button-secondary › renders secondary button correctly
src/components/card/test/clickable/card.e2e.ts › tds-card-clickable › renders clickable card correctly
src/components/card/test/default/card.e2e.ts › tds-card-default › renders default card correctly
src/components/checkbox/test/default/darkmode/checkbox.e2e.ts › tds-checkbox-darkmode › renders basic checkbox correctly
src/components/checkbox/test/default/lightmode/checkbox.e2e.ts › tds-checkbox-lightmode › renders basic checkbox correctly
src/components/checkbox/test/disabled/checkbox.e2e.ts › tds-checkbox › Hover over checkbox and label -> cursor should become inactive
src/components/checkbox/test/indeterminate/checkbox.e2e.ts › tds-checkbox › Checkbox indeterminate state
src/components/chip/test/checkbox/chip.e2e.ts › tds-chip-checkbox › renders checkbox chips correctly
src/components/chip/test/default/chip.e2e.ts › tds-chip-default › renders default chip correctly
src/components/chip/test/disabled/chip.e2e.ts › tds-chip-checkbox › renders checkbox chips correctly
src/components/chip/test/disabled/chip.e2e.ts › tds-chip-radio › renders radio chips correctly
src/components/chip/test/disabled/chip.e2e.ts › tds-chip-button › renders button chips correctly
src/components/chip/test/icon/chip.e2e.ts › tds-chip-default › renders default chip correctly
src/components/chip/test/radio/chip.e2e.ts › tds-chip-radio › renders radio chips correctly
src/components/datetime/test/default/datetime.e2e.ts › tds-datetime-default › renders datetime component correctly
src/components/datetime/test/default/datetime.e2e.ts › tds-datetime-default › icon click triggers native datetime picker
src/components/datetime/test/disabled/datetime.e2e.ts › tds-datetime-disabled › renders disabled datetime component correctly
src/components/datetime/test/error/datetime.e2e.ts › tds-datetime-error › renders disabled datetime component correctly
src/components/datetime/test/error/datetime.e2e.ts › tds-datetime-error › Simulate time selection and verify format
src/components/datetime/test/success/datetime.e2e.ts › tds-datetime-success › renders success datetime component correctly
src/components/dropdown/test/basic/dropdown.e2e.ts › tds-dropdown-basic › clicking the dropdown button opens the dropdown-list
src/components/dropdown/test/default/primary/darkmode/dropdown.e2e.ts › tds-dropdown-default-primary-darkmode › renders default dropdown correctly
src/components/dropdown/test/default/primary/darkmode/dropdown.e2e.ts › tds-dropdown-default-primary-darkmode › clicking the dropdown button opens the dropdown-list
src/components/dropdown/test/default/primary/darkmode/dropdown.e2e.ts › tds-dropdown-default-primary-darkmode › clicking the dropdown opens the dropdown-list, then click Option 1
src/components/dropdown/test/default/primary/darkmode/dropdown.e2e.ts › tds-dropdown-default-primary-darkmode › focusElement() method focus and opens the dropdown-list
src/components/dropdown/test/default/primary/lightmode/dropdown.e2e.ts › tds-dropdown-default-primary-lightmode › renders default dropdown correctly
src/components/dropdown/test/default/primary/lightmode/dropdown.e2e.ts › tds-dropdown-default-primary-lightmode › clicking the dropdown button opens the dropdown-list
src/components/dropdown/test/default/primary/lightmode/dropdown.e2e.ts › tds-dropdown-default-primary-lightmode › clicking the dropdown opens the dropdown-list, then click Option 1
src/components/dropdown/test/default/primary/lightmode/dropdown.e2e.ts › tds-dropdown-default-primary-lightmode › focusElement() method focus and opens the dropdown-list
src/components/dropdown/test/default/secondary/darkmode/dropdown.e2e.ts › tds-dropdown-default-secondary-darkmode › renders default dropdown correctly
src/components/dropdown/test/default/secondary/darkmode/dropdown.e2e.ts › tds-dropdown-default-secondary-darkmode › clicking the dropdown button opens the dropdown-list
src/components/dropdown/test/default/secondary/darkmode/dropdown.e2e.ts › tds-dropdown-default-secondary-darkmode › clicking the dropdown opens the dropdown-list, then click Option 1
src/components/dropdown/test/default/secondary/darkmode/dropdown.e2e.ts › tds-dropdown-default-secondary-darkmode › focusElement() method focus and opens the dropdown-list
src/components/dropdown/test/default/secondary/lightmode/dropdown.e2e.ts › tds-dropdown-default-secondary-lightmode › renders default dropdown correctly
src/components/dropdown/test/default/secondary/lightmode/dropdown.e2e.ts › tds-dropdown-default-secondary-lightmode › clicking the dropdown button opens the dropdown-list
src/components/dropdown/test/default/secondary/lightmode/dropdown.e2e.ts › tds-dropdown-default-secondary-lightmode › clicking the dropdown opens the dropdown-list, then click Option 1
src/components/dropdown/test/default/secondary/lightmode/dropdown.e2e.ts › tds-dropdown-default-secondary-lightmode › focusElement() method focus and opens the dropdown-list
src/components/dropdown/test/default/unspecified/dropdown.e2e.ts › tds-dropdown-default › renders default dropdown correctly
src/components/dropdown/test/default/unspecified/dropdown.e2e.ts › tds-dropdown-default › clicking the dropdown button opens the dropdown-list
src/components/dropdown/test/default/unspecified/dropdown.e2e.ts › tds-dropdown-default › clicking the dropdown opens the dropdown-list, then click Option 1
src/components/dropdown/test/default/unspecified/dropdown.e2e.ts › tds-dropdown-default › focusElement() method focus and opens the dropdown-list
src/components/dropdown/test/error/dropdown.e2e.ts › tds-dropdown-error › renders error dropdown correctly
src/components/dropdown/test/error/dropdown.e2e.ts › tds-dropdown-error › clicking the dropdown opens the dropdown-list
src/components/dropdown/test/filter/dropdown.e2e.ts › tds-dropdown-filter › renders filter dropdown correctly
src/components/dropdown/test/filter/dropdown.e2e.ts › tds-dropdown-filter › clicking the dropdown opens the dropdown-list, then start typing "iles" to only show that option in the dropdown list
src/components/dropdown/test/filter/dropdown.e2e.ts › tds-dropdown-filter › reset button icon appears when typing in the filter input
src/components/dropdown/test/filter/dropdown.e2e.ts › tds-dropdown-filter › toggle dropdown visibility and select option two
src/components/dropdown/test/filter/hide-no-result-message/dropdown.e2e.ts › tds-dropdown-filter › renders filter dropdown correctly
src/components/dropdown/test/filter/hide-no-result-message/dropdown.e2e.ts › tds-dropdown-filter › typing non existing value does not show "No results!" message
src/components/dropdown/test/filter/normalize-text-false/dropdown.e2e.ts › tds-dropdown-filter › renders filter dropdown correctly
src/components/dropdown/test/filter/normalize-text-false/dropdown.e2e.ts › tds-dropdown-filter › typing "iles" should not show anything in dropdown with normalize text set to false
src/components/dropdown/test/multiselect/dropdown.e2e.ts › tds-dropdown-multiselect › renders multiselect dropdown correctly
src/components/dropdown/test/multiselect/dropdown.e2e.ts › tds-dropdown-multiselect › clicking the dropdown opens the dropdown-list, then click Option 1, should not close it
src/components/dropdown/test/multiselect/dropdown.e2e.ts › tds-dropdown-multiselect › clicking the dropdown opens the dropdown-list, then click on all the options
src/components/dropdown/test/multiselect-filter/dropdown.e2e.ts › tds-dropdown-multiselect-filter › When focusing on the input it should clear itself
src/components/footer/test/default/footer.e2e.ts › tds-footer-default › renders default footer correctly
src/components/header/test/default/header.e2e.ts › tds-header-default › renders default header correctly
src/components/header/test/default/header.e2e.ts › tds-header-default › launcher should open on click
src/components/link/test/default/link.e2e.ts › tds-link-default › is default link rendered correctly
src/components/link/test/disabled/link.e2e.ts › tds-link-disabled › disabled link is rendered correctly
src/components/message/test/error/message.e2e.ts › tds-message-error › is error message rendered correctly
src/components/message/test/information/message.e2e.ts › tds-message-information › is information message rendered correctly
src/components/message/test/success/message.e2e.ts › tds-message-success › is success message rendered correctly
src/components/message/test/warning/message.e2e.ts › tds-message-warning › is warning message rendered correctly
src/components/modal/test/closable/modal.e2e.ts › tds-modal-closable › x button is visible
src/components/modal/test/closable/modal.e2e.ts › tds-modal-closable › x button defaults to true
src/components/modal/test/closable-false/modal.e2e.ts › x button is hidden
src/components/modal/test/default/modal.e2e.ts › tds-modal-default › renders modal correctly
src/components/modal/test/open-close/modal.e2e.ts › tds-modal-open › Modal is closed by default
src/components/modal/test/open-close/modal.e2e.ts › tds-modal-open › Clicking [Open Modal] button opens the modal
src/components/modal/test/open-close/modal.e2e.ts › tds-modal-open › Clicking [Delete] button closes the modal
src/components/popover-canvas/test/default/popover-canvas.e2e.ts › tds-popover-canvas-default › renders default popover-canvas correctly
src/components/popover-canvas/test/show-false/popover-canvas.e2e.ts › tds-popover-canvas-show-false › renders show=false popover-canvas correctly
src/components/popover-menu/test/default/popover-menu.e2e.ts › tds-popover-menu-default › renders default popover-menu correctly
src/components/popover-menu/test/icons-fluid/popover-menu.e2e.ts › tds-popover-menu-icons-fluid › renders icons-fluid popover-menu correctly
src/components/popover-menu/test/show-false/popover-menu.e2e.ts › tds-popover-menu-show-false › renders show=false popover-menu correctly
src/components/radio-button/test/default/radio-button.e2e.ts › TdsRadioButton component tests › Radio buttons with Label text = "Label text 1" and "Label text 2" render on the page
src/components/radio-button/test/disabled/radio-button.e2e.ts › Radio button - disabled state › Radio buttons with Label text = "Label text 1" and "Label text 2" renders on the page
src/components/side-menu/test/collapsible/side-menu.e2e.ts › tds-side-menu-collapsible › renders collapsible side-menu correctly
src/components/side-menu/test/default/side-menu.e2e.ts › tds-side-menu-default › renders default side-menu correctly
src/components/side-menu/test/expand-toggle/expand-toggle.e2e.ts › tds-side-menu-toggle-expand › toggle collapse and expand programmatically
src/components/side-menu/test/expand-toggle/expand-toggle.e2e.ts › tds-side-menu-toggle-expand › collapse programmatically and expand on the UI
src/components/slider/test/default/slider.e2e.ts › tds-slider-default › renders default slider correctly
src/components/slider/test/read-only/slider.e2e.ts › tds-slider-read-only › is not disabled
src/components/spinner/test/inverted/spinner.e2e.ts › tds-spinner-inverted › renders inverted spinner correctly
src/components/spinner/test/standard/spinner.e2e.ts › tds-spinner-standard › renders basic spinner correctly
src/components/stepper/test/large-horizontal-text-below/stepper.e2e.ts › Stepper - Large horizontal with text below
src/components/stepper/test/large-vertical-with-text/stepper.e2e.ts › Stepper - Large vertical with text
src/components/stepper/test/small-vertical-text-aside/stepper.e2e.ts › Stepper - Small vertical text aside
src/components/stepper/test/small-vertical-with-no-text/stepper.e2e.ts › Stepper - Small vertical with no text
src/components/table/table/test/batch/table.e2e.ts › tds-table-batch › renders batch table correctly
src/components/table/table/test/column-filtering/header-input-wrapper/interaction-fill.e2e.ts › tds-table-column-filtering fill › expect slotted inputs to persist inputed value
src/components/table/table/test/column-filtering/header-input-wrapper/interaction-focus.e2e.ts › tds-table-column-filtering focus › expect wrapper to effect slotted inputs style on focus
src/components/table/table/test/column-filtering/header-input-wrapper/interaction-hover.e2e.ts › tds-table-column-filtering hover › expect wrapper to effect slotted inputs style on hover
src/components/table/table/test/column-filtering/header-input-wrapper/table.e2e.ts › tds-table-column-filtering › renders table with editable header cell correctly
src/components/table/table/test/default/table.e2e.ts › tds-table-default › renders default table correctly
src/components/table/table/test/editing/body-input-wrapper/interaction-fill.e2e.ts › tds-table-editable-cells fill › expect slotted inputs to persist inputed value
src/components/table/table/test/editing/body-input-wrapper/interaction-focus.e2e.ts › tds-table-editable-cells focus › expect wrapper to effect slotted inputs style on focus
src/components/table/table/test/editing/body-input-wrapper/interaction-hover.e2e.ts › tds-table-editable-cells hover › expect wrapper to effect slotted inputs style on hover
src/components/table/table/test/editing/body-input-wrapper/table.e2e.ts › tds-table-editable-cells › renders table with editable cells correctly
src/components/table/table/test/expandable-row/interaction-1.e2e.ts › tds-table-expandable-row-first › under first row opened expanded row with text "Hello world 1"
src/components/table/table/test/expandable-row/interaction-2.e2e.ts › tds-table-expandable-row-second › under second row opened expanded row with text "Hello to you too"
src/components/table/table/test/expandable-row/interaction-3.e2e.ts › tds-table-expandable-row-third › under third row opened expanded row with a button with text "Call to action"
src/components/table/table/test/expandable-row/table.e2e.ts › tds-table-expandable-row › render expandable-row table correctly
src/components/table/table/test/expandable-row-expanded/expandable-row-expanded.e2e.ts › tds-table-expandable-row-expanded › first row is expanded
src/components/table/table/test/expandable-row-expanded/expandable-row-expanded.e2e.ts › tds-table-expandable-row-expanded › click on expand-input -> should become unchecked for row-id 1
src/components/table/table/test/expandable-row-methods/methods.e2e.ts › tds-table-expandable-row-methods › click expand button
src/components/table/table/test/expandable-row-methods/methods.e2e.ts › tds-table-expandable-row-methods › click collapse button
src/components/table/table/test/expandable-row-part-selector/expandable-row-expanded.e2e.ts › tds-table-expandable-row-part-selector › part selector is passing on correct background color
src/components/table/table/test/filtering/interaction.e2e.ts › tds-table-search › look for textbox and click it
src/components/table/table/test/filtering/interaction.e2e.ts › tds-table-search › clicking on search button opens field for entering data
src/components/table/table/test/filtering/table.e2e.ts › tds-table-filtering › renders filtering table correctly
src/components/table/table/test/multiselect/default/table.e2e.ts › tds-table-multiselect › renders multiselect table correctly
src/components/table/table/test/multiselect/default/table.e2e.ts › tds-table-multiselect › can check every checkbox in the table
src/components/table/table/test/multiselect/disabled-rows/table.e2e.ts › tds-table-multiselect-disabled › renders multiselect table correctly
src/components/table/table/test/multiselect/disabled-rows/table.e2e.ts › tds-table-multiselect-disabled › can check enabled checkbox in the table
src/components/table/table/test/pagination/table.e2e.ts › tds-table-pagination › renders pagination table correctly
src/components/table/table/test/pagination/table.e2e.ts › tds-table-pagination › renders pagination dropdown list correctly
src/components/table/table/test/sorting/table.e2e.ts › tds-table-sorting › renders sorting table correctly
src/components/table/table/test/sorting/table.e2e.ts › tds-table-sorting › column headers are clickable
src/components/table/table/test/zebra-mode/columns-even/table.e2e.ts › tds-table-zebra-mode-columns-even › renders default table correctly
src/components/table/table/test/zebra-mode/columns-odd/table.e2e.ts › tds-table-zebra-mode-columns-odd › renders default table correctly
src/components/table/table/test/zebra-mode/rows-even/table.e2e.ts › tds-table-zebra-mode-rows-even › renders default table correctly
src/components/table/table/test/zebra-mode/rows-odd/table.e2e.ts › tds-table-zebra-mode-rows-odd › renders default table correctly
src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts › tds-folder-tabs › renders folder-tabs correctly
src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts › tds-folder-tabs › Click on Second tab selects it and updates selected-index
src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts › tds-inline-tabs › renders inline-tabs correctly
src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts › tds-inline-tabs › Click on Second tab selects it and updates selected-index
src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts › tds-navigation-tabs › renders navigation-tabs correctly
src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts › tds-navigation-tabs › Click on Second tab selects it and updates selected-index
src/components/text-field/test/default/text-field.e2e.ts › TdsTextField - default state › renders default text-field correctly
src/components/text-field/test/password-error/text-field.e2e.ts › TdsTextField - password type with error state › renders default text-field correctly
src/components/text-field/test/password-error/text-field.e2e.ts › TdsTextField - password type with error state › should handle hover, click, and input on text field
src/components/text-field/test/read-only-success/text-field.e2e.ts › TdsTextField - read-only success state › renders readonly success state of text-field correctly
src/components/textarea/test/default/textarea.e2e.ts › tds-textarea-default › renders default textarea correctly
src/components/textarea/test/default/textarea.e2e.ts › tds-textarea-default › test if able to type in textarea
src/components/textarea/test/read-only/textarea.e2e.ts › tds-textarea-read-only › renders read-only textarea correctly
src/components/toast/test/error-with-slots/toast.e2e.ts › Toast Component Tests › should render toast component and take screenshot
src/components/toast/test/information/toast.e2e.ts › Toast Component Tests › should render toast component and take screenshot
src/components/toast/test/success-empty-action-slot/toast.e2e.ts › Toast Component Tests › should render toast component and take screenshot
src/components/toast/test/warning-not-closable/toast.e2e.ts › Toast Component Tests › should render toast component and take screenshot
src/components/toggle/test/default/toggle.e2e.ts › tds-toggle › Renders basic toggle correctly
src/components/toggle/test/default/toggle.e2e.ts › tds-toggle › Click on toggle -> should become checked
src/components/toggle/test/disabled/toggle.e2e.ts › tds-toggle › Should have disabled attribute
src/components/tooltip/test/click/tooltip.e2e.ts › tds-tooltip › renders the tooltip correctly
src/components/tooltip/test/click/tooltip.e2e.ts › tds-tooltip › Should appears on button click
src/components/tooltip/test/default/tooltip.e2e.ts › tds-tooltip › renders the tooltip correctly
src/components/tooltip/test/default/tooltip.e2e.ts › tds-tooltip › tooltip appears on button hover
src/components/tooltip/test/disabled/tooltip.e2e.ts › tds-tooltip › renders the tooltip correctly
src/components/tooltip/test/disabled/tooltip.e2e.ts › tds-tooltip › tooltip closes when cursor is removed from the button

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant