-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding config var for consumers to set and choose url to assets #906
base: develop
Are you sure you want to change the base?
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Playwright test results 173 failed Details 419 tests across 145 suites Failed testssrc/components/accordion/test/basic/accordion.e2e.ts › tds-accordion › renders basic accordion correctly Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
Quality Gate passedIssues Measures |
Describe pull-request
Consuming applications want to be able to set a configurable to choose from where assets are loaded. I have made a beta release, here is the Angular 17 one for example https://www.npmjs.com/package/@scania/tegel-angular-17/v/1.21.1-config-for-china-beta.0
Problem Statement: Immutable CDN URL in Compiled CSS
Context:
$cdn: 'https://cdn.digitaldesign.scania.com' !default;
for asset paths like fonts and logotypes.The Problem:
$cdn
variable is resolved to its value (https://cdn.digitaldesign.scania.com) during build time.Symptoms:
Underlying Cause:
$cdn
are processed during the build phase of the library and cannot be altered dynamically in the final CSS.Possible solutions:
Main idea in PR
assetSource
In connsuming applications the asset path can be oveeriden like this:
Other possible solutions
Implementation benefits
Issue Linking:
How to test
Provide detailed steps for testing, including any necessary setup.