Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add motion to accordion component #930

Closed
wants to merge 7 commits into from
Closed

feature: add motion to accordion component #930

wants to merge 7 commits into from

Conversation

ckrook
Copy link
Collaborator

@ckrook ckrook commented Dec 17, 2024 •
edited
Loading

Describe pull-request

This PR introduces motion to the accordion component.

Issue Linking:

Choose one of the following options

  • Jira: Add ticket number after CDEP-3706: CDEP-3706

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to the AWS link
  2. Navigate to the accordion component
  3. Toggle "slide" in the animation control.
  4. View animation that gets added to the accordion component.

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Screen.Recording.2024-12-17.at.16.08.10.mov

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Playwright test results

passed  420 passed
skipped  1 skipped

Details

stats  421 tests across 146 suites
duration  1 minute, 5 seconds
commit  cf3461a

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@aws-amplify-eu-north-1 AWS Amplify (eu-north-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-930.d3fazya28914g3.amplifyapp.com

@timrombergjakobsson
Copy link
Contributor

@ckrook don't forget the formatting of the title!

@ckrook ckrook changed the title Feature/accordion motion feature: add motion to accordion component Dec 18, 2024
@ckrook @timrombergjakobsson
Update packages/core/src/components/accordion/accordion-item/accordio…
af30c7b 
…n-item.scss

Co-authored-by: Tim <tim.romberg@scania.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ckrook ckrook marked this pull request as draft January 20, 2025 12:11
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Lunkan89
Copy link
Collaborator

@ckrook rebase with develop :)

@ckrook ckrook closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timrombergjakobsson timrombergjakobsson timrombergjakobsson left review comments

@mistermalm mistermalm Awaiting requested review from mistermalm mistermalm is a code owner

@theJohnnyMe theJohnnyMe Awaiting requested review from theJohnnyMe theJohnnyMe is a code owner

@EmelieLitwin EmelieLitwin Awaiting requested review from EmelieLitwin EmelieLitwin is a code owner

@nathalielindqvist nathalielindqvist Awaiting requested review from nathalielindqvist nathalielindqvist is a code owner

@Lunkan89 Lunkan89 Awaiting requested review from Lunkan89 Lunkan89 is a code owner

Assignees

@ckrook ckrook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckrook @timrombergjakobsson @Lunkan89