feature: add motion to popover component #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pover menu item transition
…with options for none and fade
ckrook
requested review from
mistermalm,
theJohnnyMe,
EmelieLitwin,
nathalielindqvist,
Lunkan89 and
timrombergjakobsson
as code owners
Playwright test results
Details
Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
* test: saving screenshots of failing tests * test: corrected output directory * test: fix output directory path * test: using artifacts upload v4 * test: reverting to older ubuntu version * test: lowering artifacts retention days
* feat(text-field): add focus method * feat(text-field): add focus method * feat(text-field): revert banner readme to previous commit * feat(text-field): revert icon readme to previous commit * feat(text-field): revert table header cell readme to previous commit * fix: call native focus method instead of dispatch event * feat(text-field): rename focusTextField to focusElement * ci: saving screenshots of failing tests (#964) * test: saving screenshots of failing tests * test: corrected output directory * test: fix output directory path * test: using artifacts upload v4 * test: reverting to older ubuntu version * test: lowering artifacts retention days * feat(text-field): add focus method * feat(text-field): add focus method * feat(text-field): revert banner readme to previous commit * feat(text-field): revert icon readme to previous commit * feat(text-field): revert table header cell readme to previous commit * fix: call native focus method instead of dispatch event * feat(text-field): rename focusTextField to focusElement --------- Co-authored-by: Johan Lundgren <johan.lundgren@umain.com> Co-authored-by: Charles Krook <charles.krook@gmail.com>
* fix: bumped to node 22.11.0 lts/jod * fix: build all after rebase * fix: bumped node version in smoke test cron action * fix: updated @types/node version
* feat(motion): add slide in/out animations and update motion parameters * test: saving screenshots of failing tests * test: corrected output directory * test: fix output directory path * test: using artifacts upload v4 * test: reverting to older ubuntu version * test: lowering artifacts retention days * feat(motion): enhance animation classes and improve visibility handling in keyframes * feat(motion): update animation styles and add new transition stories * fix: update Figma design links in motion stories * feat(motion): add slide in/out animations and update motion parameters * feat(motion): enhance animation classes and improve visibility handling in keyframes * feat(motion): update animation styles and add new transition stories * fix: update Figma design links in motion stories * feat(motion): add usage instructions for animation properties in transition stories * feat(motion): add usage instructions for animation variables in animation classes stories * feat(motion): refine animation stories and update motion variables in transitions * feat(motion): update animation variables and improve storybook examples * chore(docs): restore docs files * chore(test): remove darwin snapshots * feat(motion): refactor collapse animations to use transform scaling instead of height --------- Co-authored-by: Johan <johan.lundgren@umain.com>
…pover menu item transition
…with options for none and fade
…gital-design-system/tegel into feature/popover-motion
…gital-design-system/tegel into feature/popover-motion
…pover menu item transition
…gital-design-system/tegel into feature/popover-motion
|
@ckrook - Please rebase with fresh develop and push with force. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe pull-request
This PR applies animation "fade" to the popover-core component. This will be reflected in the popover-canvas, popover-menu.
popover-tooltip already have an animation from before, it should work as as it use to work.
Issue Linking:
Choose one of the following options
How to test
Disclaimer
We do not need to review the style of the animation, that has been covered by Charlotte
Provide detailed steps for testing, including any necessary setup.
Checklist before submission
npm run build-allwithout errorsSuggested test steps