Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add motion for dropdown component #932

Closed
wants to merge 5 commits into from

Conversation

ckrook
Copy link
Collaborator

@ckrook ckrook commented Dec 18, 2024

Describe pull-request

Introducing motion to the dropdown component

Issue Linking:

Choose one of the following options

  • Jira: Add ticket number after CDEP-3705: CDEP-

How to test

The animation style does not need to be reviewed by developers. Charlotte is reviewing the style of the animation.

Provide detailed steps for testing, including any necessary setup.

  1. Go to the AWS link
  2. Navigate to the dropdown component
  3. Toggle "slide" as animation in the controls

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

dropdown-motion.mov

Additional context

Add any other context or feedback requests about the pull-request here.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-932.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

Playwright test results

passed  418 passed
skipped  1 skipped

Details

stats  419 tests across 145 suites
duration  1 minute, 1 second
commit  6ed8170

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@ckrook ckrook closed this Jan 9, 2025
@ckrook ckrook deleted the feature/dropdown-motion branch January 9, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant