Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adding motion to button component #933

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Conversation

ckrook
Copy link
Collaborator

@ckrook ckrook commented Dec 18, 2024

Describe pull-request

In this PR we are adding animation to the button component background color

Issue Linking:

Choose one of the following options

  • Jira: Add ticket number after CDEP-3709: CDEP-3709

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to the AWS link.
  2. Navigate to the Button component
  3. Enable animation fade
  4. Make sure the button now has an small animation for the background color

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Below is the animation which we should apply on the button:
Screenshot 2024-12-18 at 16 00 39

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Playwright test results

passed  420 passed
skipped  1 skipped

Details

stats  421 tests across 146 suites
duration  1 minute, 5 seconds
commit  b9dd046

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-933.d3fazya28914g3.amplifyapp.com

@theJohnnyMe
Copy link
Contributor

theJohnnyMe commented Jan 20, 2025

Minor thing: Please double-check that "none" option is preselected in Storybook story file, right now it comes as non is selected.

Screenshot 2025-01-20 at 13 55 00

@ckrook ckrook merged commit 8a22729 into develop Jan 20, 2025
4 checks passed
@ckrook ckrook deleted the feature/button-motion branch January 20, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants