test(text-field): add screenshot tests using reusable test code #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-umain
requested review from
ckrook,
mistermalm,
theJohnnyMe,
EmelieLitwin,
nathalielindqvist,
Lunkan89 and
timrombergjakobsson
as code owners
Playwright test results
Details
Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
max-umain
force-pushed
the
test/text-field-new-screenshot-tests
branch
from
83691c4 to
6b11c6c
Compare
max-umain
changed the base branch from
develop
to
test/reusable-code-for-tests
max-umain
force-pushed
the
test/text-field-new-screenshot-tests
branch
from
c8180c4 to
eeebf92
Compare
|
ckrook
approved these changes
Jan 15, 2025
max-umain
added a commit
that referenced
this pull request
Jan 17, 2025
max-umain
added a commit
that referenced
this pull request
Jan 20, 2025
max-umain
added a commit
that referenced
this pull request
Jan 28, 2025
* test: add testConfiguration file with reusable test code * test: change testConfiguration function parameter name * test: remove undefined test configuration from testConfiguration.ts * test: improve setupPage and getTestDescribeText * test(tooltip): add screenshot tests using reusable test code (#960) * test(tooltip): use reusable test code for lightmode and darkmode screenshot tests * test(tooltip): move non-screenshot tests to not run for all style configurations * test(toggle): add screenshot tests using reusable test code (#959) * test(toggle): add screenshot tests using reusable test code * test(toggle): move non-screenshot tests to not run for all style configurations * test(toggle): remove old screenshots * test(slider): add screenshot tests using reusable test code (#953) * test(toast): add screenshot tests using reusable test code (#958) * test(textarea): add screenshot tests using reusable test code (#957) * test(text-field): add screenshot tests using reusable test code (#956) * test(side-menu): add screenshot tests using reusable test code (#952) * test(radio-button): add screenshot tests using reusable test code (#951) * test(popover menu): add screenshot tests using reusable test code (#950) * test(popover-canvas): add screenshot tests using reusable test code (#949) * test(message): add screenshot tests using reusable test code (#948) * test(chip): add screenshot tests using reusable test code (#947) * test(link): add screenshot tests using reusable test code (#946) * test(header): add screenshot tests using reusable test code (#945) * test(footer): add screenshot tests using reusable test code (#944) * test(dropdown): improved and added more screenshot tests with reusable test code (#943) * test(datetime): update and improve lightmode and darkmode screenshot tests, with reusable test code (#942) * test(checkbox): more and improved screenshot tests using reusable test code (#941) * test(card): use reusable test code for lightmode and darkmode screenshot tests (#940) * test(button): new and improved screenshot tests with reusable test code (#938) * test(breadcrumbs): improved screenshot tests with reusable code (#937) * test(banner): improved and more screenshot tests with reusable code (#936) * test(accordion): more screenshot tests with reusable code (#935) * test(tabs): add screenshot tests using reusable test code (#955) * test(table): add screenshot tests using reusable test code (#954) * test: make testConfiguration.ts more general * test(stepper): add screenshot tests using reusable test code (#971) * test(modal): add screenshot tests using reusable test code (#970) * test(divider): add screenshot tests using reusable test code (#969) * test(block): add screenshot tests using reusable test code (#968) * test(spinner): add screenshot tests using reusable test code (#972) * test(dropdown): update screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe pull-request
Adds screenshot tests for text-field in lightmode and darkmode, using the reusable test code.
Issue Linking:
How to test
npm run testChecklist before submission
npm run build-allwithout errorsSuggested test steps
Screenshots
Not applicable
Additional context
For one of the tests in read-only-success, the color of an element is checked. This doesn't work when the mode or mode variant changes, because that also changes the color. So, I simply skip that test now when we have a configuration. Let me know if this should be handled for all modes and mode variants.