Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(motion): Storybook variable documentation #966

Merged
merged 24 commits into from
Jan 17, 2025

Conversation

ckrook
Copy link
Collaborator

@ckrook ckrook commented Jan 16, 2025

Describe pull-request

This PR adds documentation for motion transition & animation variables in Storybook.
This PR also renames the motion variables to better align with Figma Design system naming.

Issue Linking:

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to AWS Storybook link
  2. In the left sidebar, navigate to category "Motion".
  3. Inspect both the Transition & Animation folder and make sure no odd behavior here.

Charlotte will review the actual animations from a design point of view.

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Additional context

I have renamed the motion variables so I would consider this PR a minor breaking change

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-966.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Playwright test results

passed  420 passed
skipped  1 skipped

Details

stats  421 tests across 146 suites
duration  1 minute, 10 seconds
commit  8b8fbe0

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@theJohnnyMe
Copy link
Contributor

@ckrook please do this:
1 . Rebase PR with latest develop on local so we do not see other code but only your changes
2. Check that "STORYBOOK_ENV" variable is inactive, now _beta components made their way in the code

Copy link
Collaborator

@Lunkan89 Lunkan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the .darwin screenshots can be removed since there generated for local test run?

motion/_animation.scss Outdated Show resolved Hide resolved
motion/_animation.scss Outdated Show resolved Hide resolved
motion/_animation.scss Outdated Show resolved Hide resolved
motion/_animation.scss Outdated Show resolved Hide resolved
motion/_animation.scss Outdated Show resolved Hide resolved
motion/_animation.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements and Storybook docs!

@ckrook ckrook merged commit 4d71e5c into develop Jan 17, 2025
4 checks passed
@ckrook ckrook deleted the feature/storybook-animation-page branch January 17, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants