-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(motion): Storybook variable documentation #966
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Playwright test resultsDetails 421 tests across 146 suites Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
…/scania-digital-design-system/tegel into feature/storybook-animation-page
@ckrook please do this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the .darwin
screenshots can be removed since there generated for local test run?
…/scania-digital-design-system/tegel into feature/storybook-animation-page
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements and Storybook docs!
Describe pull-request
This PR adds documentation for motion transition & animation variables in Storybook.
This PR also renames the motion variables to better align with Figma Design system naming.
Issue Linking:
How to test
Provide detailed steps for testing, including any necessary setup.
Charlotte will review the actual animations from a design point of view.
Checklist before submission
npm run build-all
without errorsSuggested test steps
Additional context
I have renamed the motion variables so I would consider this PR a minor breaking change